Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe to change song in now playing #1017

Open
3 tasks done
Coolbeans1388 opened this issue Sep 2, 2023 · 5 comments
Open
3 tasks done

Swipe to change song in now playing #1017

Coolbeans1388 opened this issue Sep 2, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Coolbeans1388
Copy link

Checklist

  • I've checked that there is no other issue about this feature request.
  • This issue contains only one feature request.
  • The title of this issue accurately describes the feature request.

Feature description

Latest update removed ability to swipe to change song on now playing screen.

Why do you want this feature?

I miss this feature from last version.

Additional information

No response

@Coolbeans1388 Coolbeans1388 added the enhancement New feature or request label Sep 2, 2023
@z-huang
Copy link
Owner

z-huang commented Sep 2, 2023

Yeah it's removed because it's not stable. Once I find a better way to implement, I'll add it back.

@netrunner-exe
Copy link
Contributor

netrunner-exe commented Sep 2, 2023

Yeah it's removed because it's not stable. Once I find a better way to implement, I'll add it back.

Hi @z-huang! Is it possible this buggy behavior is because the indexes are not updating correctly when a track is swiped, maybe it has something to do with the track indexes in the queue? I had this bug when a track in the queue is moved above what is playing now (and accordingly sometimes on the screen quick picks, maybe also related to queue?). I don't know for sure, just a guess.

@z-huang
Copy link
Owner

z-huang commented Sep 3, 2023

Yeah, it's related to the queue. When the queue is changed, the HorizontalPager will do the animation. Somehow it detects a move action by mistake and change the track accordingly.

@z-huang z-huang mentioned this issue Sep 4, 2023
3 tasks
@Vishcot
Copy link

Vishcot commented Sep 6, 2023

what if we try to integrate Bottom to Top swiping gestures for changing songs like Resso App, Wynk and Gaana app have now implemented, it is much more convenient and more interactive @z-huang

@d4f5409d
Copy link

Retro Music Player has it nicely implemented, you may take a look at their code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants