Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Bot messages are still cumbersome und not useful for users #7

Closed
wzrdtales opened this issue Feb 26, 2018 · 5 comments
Closed

Bot messages are still cumbersome und not useful for users #7

wzrdtales opened this issue Feb 26, 2018 · 5 comments

Comments

@wzrdtales
Copy link

Since I repeatedly receive questions, I will open this ticket here now. The bot message should include a link to the conventions, otherwise new users have no clue at all, what is happening.

So a link pointing the user to the convention, probably https://github.com/conventional-changelog/conventional-changelog/tree/35e60b5be6027fb2784c5103eee111f6f99b045e/packages/conventional-changelog-angular, would be immmensly helpful.

db-migrate/node-db-migrate#549 (comment)

@marionebl
Copy link

I think this is an issue with commitlint itself: https://github.com/marionebl/commitlint/issues/206

Especially commits the conventional-commits-parser can’t derive a header (type, subject) from produce confusing error messages right now.

@stevenh
Copy link

stevenh commented Jun 29, 2018

I agree I just submitted caarlos0/env#53 which errored with:

Commit: 036d649
✖ message may not be empty
, - ✖ type may not be empty

I had no idea what it was on about as message was definitely there i.e. subject and message and I had no clue what was meant by type.

I followed the links provided by the bot but there's nothing in this projects README.md that details what it checks. It was only when I found this bug report and the link in it which allowed me to determine what I needed to change to get my commit message to pass the linter.

Improving the messaging would really help prevent wasting users time, hunting around for what the linter actually meant.

@caarlos0
Copy link
Contributor

Agree as well... messages look really weird and are not very useful to someone who does not know the commit msg rules...

@abma
Copy link

abma commented Nov 13, 2018

yeah, what does "message may not be empty" and "type may not be empty" mean? wtf?

@caarlos0
Copy link
Contributor

caarlos0 commented Oct 3, 2019

tried something at #18, please let me know what you think :)

@z0al z0al closed this as completed Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants