Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nitpick: Use Releases and curl instead of git clone #1

Open
zbruhnke opened this issue Dec 31, 2019 · 1 comment · May be fixed by #9
Open

Nitpick: Use Releases and curl instead of git clone #1

zbruhnke opened this issue Dec 31, 2019 · 1 comment · May be fixed by #9
Assignees
Labels
enhancement New feature or request

Comments

@zbruhnke
Copy link

RUN git clone https://github.com/duo-labs/cloudmapper.git /opt/secops/cloudmapper && \

Just adding this hear as a suggestion mostly AFAICT there is no reason you need git installed here other than the fact that you're cloning entire repos to install them.

However Github has a "release" feature and all the repos you're downloading utilize them. This would allow you to save installing git, just do this with curl and have a lot less work to do installing and building this image.

I also think it would make it cleaner especially because Github makes it easy to package releases for specific OS's so you could only download a .deb file if they are to make one available at some point.

Overall kudos on putting something together and trying to be useful to the community.

@z0ph
Copy link
Owner

z0ph commented Jan 1, 2020

Thanks for your useful feedback, will add this in the next release. Seems legit :)

@z0ph z0ph added the enhancement New feature or request label Jan 1, 2020
@z0ph z0ph self-assigned this Jan 1, 2020
@z0ph z0ph linked a pull request May 23, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants