-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lego Power Functions tests #336
Conversation
This will be put on hold while we figure things out at #333 |
BitStreamEncoder is actually a protocol implementation that plugs into a simple, straight forward IRsend send function. I'm sure whatever the outcome of #333 is, the Lego Power Functions part can be easily adapted to match the new structure. Let me know when you are ready.
|
Add ATmega48 and ATmega88 to the list (+ some other minor commits)
In that case, I might as well implement this as it may be a while until we have #333 sorted out, if possible please check and update the PR against master as I just merged another PR so that would have offset your commits |
Misleading link to "tutorials and more information"
@z3t0 I updated against master. The PR is ready to be merged. |
Looks good, just one more thing, please add your changes to the changelog and just bump the version |
@z3t0 Changelog and versions are up-to-date now |
Thank you for your efforts! and I apologize for not helping out with the merge. |
Add Lego Power Functions tests
I moved the BitStreamEncoder code to a separate header file in order to allow basic unit testing with a dedicated test sketch.