Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lower-Case "cadence" as an Alias for Cadence #122

Open
Karenwithakay opened this issue Apr 13, 2023 · 3 comments
Open

Add Lower-Case "cadence" as an Alias for Cadence #122

Karenwithakay opened this issue Apr 13, 2023 · 3 comments
Assignees
Labels
config Issues or pull requests which involve changes to config enhancement quality-of-life Small issues which don't add functionality, but improve things from a development standpoint question

Comments

@Karenwithakay
Copy link
Collaborator

Discord bot should accept user commands as cadence or Cadence.
All commands that appear on the discord bot's help menu should be able to get accessed via lower or upper case Cadence.
OR Help Menu/Description should explain that commands only work if typed out with a capital c.

As a user with no prior knowledge of the bot, it took me a hot sec to realize the commands needed to be typed out with a capital c. This would also be very useful for desktop users who don't have auto-correct/capitalization at the beginning of sentences/new messages.
I imagine a desired, regular user would be using Cadence bot casually and not consider grammar as they would if writing an essay or working on a project.

:D

@Karenwithakay Karenwithakay added the quality-of-life Small issues which don't add functionality, but improve things from a development standpoint label Apr 13, 2023
@Karenwithakay
Copy link
Collaborator Author

I realize Cadence help menu does include quotations, which mean the command has to be written WITH a capital c to work. Regardless, I still think this would be a quality of life improvement for regular users.

@za419
Copy link
Owner

za419 commented Apr 13, 2023

I realize Cadence help menu does include quotations, which mean the command has to be written WITH a capital c to work. Regardless, I still think this would be a quality of life improvement for regular users.

It does, but there are other aliases we allow:
image

So it's fine. The way I see it, the way it's written in the helptext must work, but that doesn't mean only that can work (or else we wouldn't have aliases at all)

... Perhaps we should change the helptext to use code blocks instead of "quotations" though, if you feel that'd be more clear?

@za419
Copy link
Owner

za419 commented Apr 13, 2023

I believe this behavior should be configurable by the IA, and set to enabled by default (in other words, it shouldn't be hardcoded to be this way, but if you want it off you should need to open config and disable it for yourself)

Questions (not exclusively to be answered by @Karenwithakay) if other people have an opinion:

  1. Should this apply to recognition of custom commands? I won't add this for admin-only ones (it shouldn't necessarily be easy to accidentally ban someone or something like that), but we could add it for things like "Cadence introduce yourself" => "cadence introduce yourself" as long as it was done in a way that didn't remove caps (ie "cadence echo Hello World" should reply "Hello World", not "hello world" or "HELLO WORLD")
  2. Should this be configurable individually (we just add new aliases to the list above for each command), or globally (we have a setting to enable this behavior for everything at once)?
    • It's worth noting that it's already "configurable individually" using the alias mechanism - But we're talking about setting them by default for that option.
  3. Should it apply only for the first letter, or should the whole recognition be case-insensitive?
    • That is to say, should it only accept "Cadence play" and "cadence play", or should "CaDeNcE pLaY" and "cadence Play" also work?
    • It's worth noting the second one is impractical with the aliases approach - There are simply too many combinations of capitalization to alias individually. If we choose the second, we shall choose to use a global switch
    • This is not necessarily an either/or sort of option - Instead of making the global switch something like "commandCaseSensitive": true|false, we could use a "commandCaseSensitivity": "strict"|"permissive"|"none" sort of thing. We would still need to think about what the default is, but I would not mind at all letting an IA choose as they desire.

@za419 za419 added enhancement question config Issues or pull requests which involve changes to config labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Issues or pull requests which involve changes to config enhancement quality-of-life Small issues which don't add functionality, but improve things from a development standpoint question
Projects
None yet
Development

No branches or pull requests

2 participants