-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] - can't save history #108
[bug] - can't save history #108
Comments
I need some information: What is your platform ? Version of vscode ? Inside ? Settings ? Open file, folder, workspace ? I know there is still problem with external path location, (compare, restore) |
Settings: {
"workbench.iconTheme": "material-icon-theme",
"workbench.colorTheme": "Dracula",
"workbench.startupEditor": "newUntitledFile",
"terminal.integrated.fontSize": 14,
"terminal.integrated.shell.osx": "/bin/zsh",
"editor.tabSize": 2,
"editor.fontSize": 18,
"editor.lineHeight": 24,
"editor.fontFamily": "Fira Code",
"editor.fontLigatures": true,
"explorer.compactFolders": false,
"editor.renderLineHighlight": "gutter",
"workbench.editor.labelFormat": "short",
"extensions.ignoreRecommendations": true,
"javascript.updateImportsOnFileMove.enabled": "never",
"breadcrumbs.enabled": true,
"editor.parameterHints.enabled": false,
"typescript.updateImportsOnFileMove.enabled": "never",
"explorer.confirmDragAndDrop": false,
"explorer.confirmDelete": false,
"editor.rulers": [80, 120],
"files.autoSave": "onFocusChange",
"editor.formatOnPaste": true,
"editor.formatOnSave": true,
"editor.formatOnType": true,
"workbench.preferredDarkColorTheme": "Dracula",
"workbench.preferredHighContrastColorTheme": "Dracula",
"workbench.preferredLightColorTheme": "Dracula",
"eslint.alwaysShowStatus": true,
"eslint.format.enable": true,
"[jsonc]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"debug.extensionHost.useV3": true,
"[javascript]": {
"editor.codeActionsOnSave": {
"source.organizeImports": true,
"source.fixAll.eslint": true,
}
},
"[javascriptreact]": {
"editor.codeActionsOnSave": {
"source.organizeImports": true,
"source.fixAll.eslint": true,
}
},
"[typescript]":{
"editor.codeActionsOnSave": {
"source.organizeImports": true,
"source.fixAll.eslint": true,
}
},
"[typescriptreact]":{
"editor.codeActionsOnSave": {
"source.organizeImports": true,
"source.fixAll.eslint": true,
}
}
} Version: 1.44.0 |
@misaku I had the same problem when invoking VSCode via cli on individual files. But if you open a folder (workspace), local-history starts working as expected. |
but in my case is a folder worksapce =( |
I"m having the same problem. Version: 1.52.1 settings.json
I'm opening a workspace. I'm using the dart-code extension if that's important. I've tried uninstalling/restart vscode/re-install to no affect. There is a .history in each project folder as well as the workspace. I suspect this is because occasionally I've opened individual folders directly. The workspace level .history folder structure seems to be populated but no files. Is there any way to diagnose the problem? |
I am having the same problem, I have the same configuration as @bsutton. How can we diagnose this? |
Same issue with a snap version of VS Code on Ubuntu 20.04. I tried disabling other extensions, installing previous versions of this extension with no effect. It used to work, I didn't notice at first when it stopped doing so. There are no errors in the VS Code logs. I tried tweaking the options with no effect. When I modify a file, its path is created in the .history folder, but not the file itself. Quite distressing. |
I seem to be experiencing the same issue with VS Code 1.53.2 running on Ubuntu 20.04 |
Same here. Doesn't work at all, the history is always empty. Tried to reinstall, restart VSCode, nothing helps. Mint 20. |
I did a short debug session. The history file is successfully created here local-history/src/history.controller.ts Line 255 in 0543d2d
|
@zabel-xyz I found out that the history is deleted after the specified seconds in the settings local-history.saveDelay. Sounds crazy but it is. For OP it is 0 seconds so... VSCode:
edit: local-history/src/history.controller.ts Line 508 in 0543d2d
because
https://askubuntu.com/a/918303
https://nodejs.org/api/fs.html#fs_stat_time_values so stat on some OS/FS may return empty "birthtime" for files
|
Hi, |
I try to use local history, but I can't.
the history saves, but at the same time deletes the history. and I can't use that.
but if i set a specific location it works, but not very well, it can be saved, but i need to go to the history path and in the file to compare.
The text was updated successfully, but these errors were encountered: