Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plsql.configuration.json #29

Closed
wants to merge 1 commit into from
Closed

Update plsql.configuration.json #29

wants to merge 1 commit into from

Conversation

Danieleeee
Copy link

Hi,
what is it for /" ?
I added ["*", "*/"] for autoclosing comments.
Removed [ ] which are never used.

what do you think about?

@Danieleeee
Update plsql.configuration.json
df0227f 
Hi,
what is it for /" ?
I added ["\*", "*/"] for autoclosing comments.
Removed [ ] which are never used.

what do you think about?
@zabel-xyz
Copy link
Owner

zabel-xyz commented Oct 26, 2017 •
edited
Loading

what is it for /" ?
=> to use double-quote.
I know simple quote is more common in oracle, but double quote can be usefull too, please don't delete it !
I added ["/*", "*/"] for autoclosing comments.
=> Ok, this was missing
Removed [ ] which are never used.
=> Ok, not used

@Danieleeee
Copy link
Author

Thanks,
I hope you will soon be able to implement other Pull requests and Issues as well.
Bye.

zabel-xyz added a commit that referenced this pull request Oct 29, 2017
@zabel-xyz
#29 Improve plsql.configuration
3d1225d
@zabel-xyz
Copy link
Owner

I push some improvement in plsql.configuration.json
(Not pubilshed yet)

@zabel-xyz
Copy link
Owner

Fix in version 1.1.0

@zabel-xyz zabel-xyz closed this Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Danieleeee @zabel-xyz