Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Games downloaded in 3 not recognised as already downloaded in 4 #319

Open
djay opened this issue Dec 25, 2024 · 3 comments
Open

Games downloaded in 3 not recognised as already downloaded in 4 #319

djay opened this issue Dec 25, 2024 · 3 comments

Comments

@djay
Copy link
Contributor

djay commented Dec 25, 2024

I've set up the download folder the same. So not sure why it attempts to download the game again.

@zach-morris
Copy link
Owner

zach-morris commented Dec 26, 2024

You got an example and/or debug log?
File matching is as follows (code here):

  1. Get a list of all files in the download path for this game list
  2. See if there are any exact matches for the requested 'launch file' (certain game lists require a conf file or cmd file, etc to launch, Beneath a Steel Sky (DOS, Floppy).scummvm for example would match with https://archive.org...Beneath%20a%20Steel%20Sky%20(DOS, Floppy).zip)
  3. See if there are any exact matches for the file requested to be downloaded (Mario (USA).zip for example would match with https://archive.org....Mario%20(USA).zip)
  4. See if there are any stem (filename without extension) matches for the file requested to be downloaded (Mario (USA).nes for example would match with https://archive.org....Mario%20(USA).zip)
  5. See if the string of the file stem requested is in the requested download path (this catches any files that aren't named exactly as needed after extraction, this seems to happen mainly with hacks and translations (Mario (USA) (T-En).nes for example would match with https://archive.org....Mario%20(USA) (T-En) [translation by XYZ].zip)

In order, just use the first match found, if any. If no match, continue with download. If the file doesn't match exactly any of these conditions, it should be re-downloaded. I haven't been able to find an example (yet) where this didn't catch a locally available file, but if there are any let me know.

@djay
Copy link
Contributor Author

djay commented Jan 6, 2025

here is one example.

In 4 - Sony\ PlayStation\ Portable/Daxter\ (US).iso
In 3 - Playstation_Portable/Daxter\ (USA)\ (En,Fr,De,Es,It).iso

@zach-morris
Copy link
Owner

zach-morris commented Jan 6, 2025

Yeah, the archive is not the same. The game filename is different and they don't match. This isn't usually a problem if one archive is no longer available and the new archive uses the same filenames, but this one doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants