Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature request) Add non-intrusive internet connection lost message #2366

Open
1 task done
Myzel394 opened this issue Nov 21, 2021 · 7 comments · May be fixed by #2381
Open
1 task done

(Feature request) Add non-intrusive internet connection lost message #2366

Myzel394 opened this issue Nov 21, 2021 · 7 comments · May be fixed by #2381
Labels
Type: Enhancement

Comments

@Myzel394
Copy link
Contributor

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe feature

When you have no internet connection and try to open notes, you will always get these notification boxes. They are not really understandable by people who are not versatile with computers.

I would suggest creating a non-intrusive banner at the top that shows that the internet is missing (see screenshot example from protonmail.com)

image

Additional Information

No response
@zadam
Copy link
Owner

zadam commented Nov 21, 2021

Hi, do you mean on server version? Since on desktop for opening notes you don't need internet connection. Internet is needed for sync only and with that lack of internet is silent (only sync status icon changes). It would be useful if you could provide a screenshot and more context. Thx.

@Myzel394
Copy link
Contributor Author

Yes I mean the the server version.

Here's what we could implement:

image

@Myzel394
Copy link
Contributor Author

@zadam what do you think?

@zadam
Copy link
Owner

zadam commented Nov 23, 2021

I guess why not?

(although it seems a bit ... superfluous? I mean with webapps running in a browser there is a general understanding that they don't work offline)

@Myzel394
Copy link
Contributor Author

although it seems a bit ... superfluous? I mean with webapps running in a browser there is a general understanding that they don't work offline

Yes of course :D, but at least we don't get spammed with this box notification which is exactly in the center of the page and is kind of annoying once you realize you don't have any internet

@zadam
Copy link
Owner

zadam commented Nov 23, 2021

Ok, I'm not against this if you're willing to submit a PR.

@Myzel394
Copy link
Contributor Author

Btw, does anyone know if there's a name for this kind of message?

@Myzel394 Myzel394 linked a pull request Nov 25, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add top banner Myzel394/trilium
2 participants
@zadam @Myzel394