You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Builder constructor throws an error if element id is passed to it as string.
classBuilder{constructor(mapData,modelData,embeddedCss,selection,options){// Defaultsif(!selection){selection=d3Select('body').append('div')}elseif(selectioninstanceofd3Selection){// D3 V4 selection}elseif('node'inselection){// If user passes in a selection from an different d3 version/instance,// then reselect.selection=d3Select(selection.node())}else{// HTML Elementselection=d3Select(selection)}
Would add additional check here:
classBuilder{constructor(mapData,modelData,embeddedCss,selection,options){// Defaultsif(!selection){selection=d3Select('body').append('div')}elseif(selectioninstanceofd3Selection){// D3 V4 selection}elseif(typeofselection==='object'&&'node'inselection){// If user passes in a selection from an different d3 version/instance,// then reselect.selection=d3Select(selection.node())}else{// HTML Elementselection=d3Select(selection)}
The text was updated successfully, but these errors were encountered:
pitkunait
changed the title
issue with passing selection HTML element id to Builder constructor
issue when HTML element's id string is passed to Builder constructor
Feb 3, 2021
pitkunait
changed the title
issue when HTML element's id string is passed to Builder constructor
Issue when HTML element's id string is passed to Builder constructor
Feb 3, 2021
pitkunait
changed the title
Issue when HTML element's id string is passed to Builder constructor
Issue when HTML element's id string is passed to Builder constructor😡
Feb 3, 2021
pitkunait
changed the title
Issue when HTML element's id string is passed to Builder constructor😡
Issue when HTML element's id string is passed to Builder constructor
Feb 3, 2021
Builder constructor throws an error if element id is passed to it as string.
Would add additional check here:
The text was updated successfully, but these errors were encountered: