Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align mask? #11

Open
kvark opened this issue Nov 4, 2020 · 1 comment
Open

Align mask? #11

kvark opened this issue Nov 4, 2020 · 1 comment

Comments

@kvark
Copy link
Contributor

kvark commented Nov 4, 2020

From the implementation perspective, I can see how align mask would be more convenient. But from the API perspective in the Request, it's not very nice. For one, it's not clear if the mask is just supposed to be alignment - 1 or the !(alignment - 1) from the documentation. Would it be simpler to just receive the alignment and document that it has to be a power of 2?
@zakarumych
Copy link
Owner

I guess you're right that receiving alignment value would make API more intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @zakarumych