Skip to content

Commit ca96ab2

Browse files
authored
Merge pull request quarkusio#30932 from ozangunalp/remove_vertx_kafka_client_dependency
Remove vertx-kafka-client dependency from smallrye-reactive-messaging-kafka
2 parents 32d7672 + 17ad275 commit ca96ab2

File tree

9 files changed

+56
-240
lines changed

9 files changed

+56
-240
lines changed

bom/application/pom.xml

-31
Original file line numberDiff line numberDiff line change
@@ -5229,37 +5229,6 @@
52295229
<artifactId>client</artifactId>
52305230
<version>${scram-client.version}</version>
52315231
</dependency>
5232-
<dependency>
5233-
<groupId>io.vertx</groupId>
5234-
<artifactId>vertx-kafka-client</artifactId>
5235-
<version>${vertx.version}</version>
5236-
<exclusions>
5237-
<exclusion>
5238-
<groupId>com.fasterxml.jackson.core</groupId>
5239-
<artifactId>jackson-core</artifactId>
5240-
</exclusion>
5241-
<exclusion>
5242-
<groupId>com.fasterxml.jackson.module</groupId>
5243-
<artifactId>jackson-module-scala_2.12</artifactId>
5244-
</exclusion>
5245-
<exclusion>
5246-
<groupId>org.scala-lang</groupId>
5247-
<artifactId>scala-reflect</artifactId>
5248-
</exclusion>
5249-
<exclusion>
5250-
<groupId>org.apache.kafka</groupId>
5251-
<artifactId>kafka-clients</artifactId>
5252-
</exclusion>
5253-
<exclusion>
5254-
<groupId>com.101tec</groupId>
5255-
<artifactId>zkclient</artifactId>
5256-
</exclusion>
5257-
<exclusion>
5258-
<groupId>org.slf4j</groupId>
5259-
<artifactId>slf4j-log4j12</artifactId>
5260-
</exclusion>
5261-
</exclusions>
5262-
</dependency>
52635232
<dependency>
52645233
<groupId>com.cronutils</groupId>
52655234
<artifactId>cron-utils</artifactId>

extensions/smallrye-reactive-messaging-kafka/deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/kafka/deployment/KafkaCodecProcessor.java

-75
This file was deleted.

extensions/smallrye-reactive-messaging-kafka/deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/kafka/deployment/SmallRyeReactiveMessagingKafkaProcessor.java

+6-14
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import io.smallrye.mutiny.tuples.Functions.TriConsumer;
4949
import io.smallrye.reactive.messaging.kafka.KafkaConnector;
5050
import io.smallrye.reactive.messaging.kafka.commit.ProcessingState;
51-
import io.vertx.kafka.client.consumer.impl.KafkaReadStreamImpl;
5251

5352
public class SmallRyeReactiveMessagingKafkaProcessor {
5453

@@ -64,13 +63,6 @@ FeatureBuildItem feature() {
6463

6564
@BuildStep
6665
public void build(BuildProducer<ReflectiveClassBuildItem> reflectiveClass) {
67-
// Required for the throttled commit strategy
68-
reflectiveClass.produce(
69-
ReflectiveClassBuildItem.builder(KafkaReadStreamImpl.class)
70-
.fields(true)
71-
.methods(true)
72-
.constructors(true)
73-
.build());
7466
reflectiveClass.produce(new ReflectiveClassBuildItem(true, true, ProcessingState.class));
7567
}
7668

@@ -680,9 +672,9 @@ private static boolean isRawMessage(Type type) {
680672
// Kafka types
681673
Map.entry(DotName.createSimple(org.apache.kafka.common.utils.Bytes.class.getName()), org.apache.kafka.common.serialization.BytesDeserializer.class.getName()),
682674
// Vert.x types
683-
Map.entry(DotName.createSimple(io.vertx.core.buffer.Buffer.class.getName()), io.vertx.kafka.client.serialization.BufferDeserializer.class.getName()),
684-
Map.entry(DotName.createSimple(io.vertx.core.json.JsonObject.class.getName()), io.vertx.kafka.client.serialization.JsonObjectDeserializer.class.getName()),
685-
Map.entry(DotName.createSimple(io.vertx.core.json.JsonArray.class.getName()), io.vertx.kafka.client.serialization.JsonArrayDeserializer.class.getName())
675+
Map.entry(DotName.createSimple(io.vertx.core.buffer.Buffer.class.getName()), io.quarkus.kafka.client.serialization.BufferDeserializer.class.getName()),
676+
Map.entry(DotName.createSimple(io.vertx.core.json.JsonObject.class.getName()), io.quarkus.kafka.client.serialization.JsonObjectDeserializer.class.getName()),
677+
Map.entry(DotName.createSimple(io.vertx.core.json.JsonArray.class.getName()), io.quarkus.kafka.client.serialization.JsonArrayDeserializer.class.getName())
686678
);
687679

688680
private static final Map<DotName, String> KNOWN_SERIALIZERS = Map.ofEntries(
@@ -709,9 +701,9 @@ private static boolean isRawMessage(Type type) {
709701
// Kafka types
710702
Map.entry(DotName.createSimple(org.apache.kafka.common.utils.Bytes.class.getName()), org.apache.kafka.common.serialization.BytesSerializer.class.getName()),
711703
// Vert.x types
712-
Map.entry(DotName.createSimple(io.vertx.core.buffer.Buffer.class.getName()), io.vertx.kafka.client.serialization.BufferSerializer.class.getName()),
713-
Map.entry(DotName.createSimple(io.vertx.core.json.JsonObject.class.getName()), io.vertx.kafka.client.serialization.JsonObjectSerializer.class.getName()),
714-
Map.entry(DotName.createSimple(io.vertx.core.json.JsonArray.class.getName()), io.vertx.kafka.client.serialization.JsonArraySerializer.class.getName())
704+
Map.entry(DotName.createSimple(io.vertx.core.buffer.Buffer.class.getName()), io.quarkus.kafka.client.serialization.BufferSerializer.class.getName()),
705+
Map.entry(DotName.createSimple(io.vertx.core.json.JsonObject.class.getName()), io.quarkus.kafka.client.serialization.JsonObjectSerializer.class.getName()),
706+
Map.entry(DotName.createSimple(io.vertx.core.json.JsonArray.class.getName()), io.quarkus.kafka.client.serialization.JsonArraySerializer.class.getName())
715707
);
716708
// @formatter:on
717709

0 commit comments

Comments
 (0)