New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve favicon scraping/conversion #40

Open

zaknesler opened this issue May 27, 2024 · 0 comments

Owner

zaknesler commented May 27, 2024

Right now SVG favicons do not get parsed by https://github.com/Pascal736/favilib, so I think the best course is to scrape the favicon ourself and convert SVGs to the PNG data string.

Also, that conversion isn't even working with that library even when it can find the favicons, so we'll need to fix that anyway!

zaknesler changed the title ~~Improve favicon parsing~~ Improve favicon scraping/conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment