Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add stylelint and fix CSS errors #845

Merged
merged 5 commits into from
Dec 23, 2024
Merged

fix: add stylelint and fix CSS errors #845

merged 5 commits into from
Dec 23, 2024

Conversation

targos
Copy link
Member

@targos targos commented Dec 20, 2024

No description provided.

@targos targos requested a review from tpoisseau December 20, 2024 12:34
Copy link

cloudflare-workers-and-pages bot commented Dec 20, 2024

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: 74e9c2d
Status: ✅  Deploy successful!
Preview URL: https://3e8061ef.react-science.pages.dev
Branch Preview URL: https://stylelint.react-science.pages.dev

View logs

@stropitek
Copy link
Contributor

💯

package.json Outdated Show resolved Hide resolved
src/components/accordion/accordion.tsx Show resolved Hide resolved
stories/components/tabs.stories.tsx Outdated Show resolved Hide resolved
targos and others added 3 commits December 20, 2024 15:26
Co-authored-by: tpoisseau <22891227+tpoisseau@users.noreply.github.com>
@targos targos requested a review from tpoisseau December 23, 2024 13:49
Copy link

@tpoisseau tpoisseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

#845 (comment)
I let you fix this or confirm it's on purpose

@targos
Copy link
Member Author

targos commented Dec 23, 2024

It is fixed by 685f231

@targos
Copy link
Member Author

targos commented Dec 23, 2024

I let you look again at the diff since you missed it

Copy link

@tpoisseau tpoisseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos merged commit 238e55a into main Dec 23, 2024
13 checks passed
@targos targos deleted the stylelint branch December 23, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants