Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

create datalake plugin #393

Closed
wants to merge 11 commits into from
Closed

Conversation

drummerwolli
Copy link
Contributor

fix #351

the DL has an API. You submit a query, then wait for it to finish, and then retrieve the results. I modeled now the most basic plugin I could think of which is executing this flow.

Comments/feedback on this highly appreciated!

disclaimer:

  • never did something in python2
  • can't test locally due to broken setup
  • have not tried it with the actual data lake (don't know how)

@drummerwolli drummerwolli mentioned this pull request Mar 7, 2019
@drummerwolli
Copy link
Contributor Author

#394 needs to get merged first ...

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #393 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   75.73%   75.54%   -0.19%     
==========================================
  Files          80       80              
  Lines        5918     5918              
==========================================
- Hits         4482     4471      -11     
- Misses       1436     1447      +11
Impacted Files Coverage Δ
zmon_worker_monitor/workflow.py 68.7% <0%> (-3.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a38dc...35998a5. Read the comment docs.

@mohabusama
Copy link
Contributor

Thanks!
Since this is a very specific plugin (not very useful in non-OSS context), I suggest moving it to zmon-extras plugins.

@pitr pitr closed this Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[internal] support DL queries
3 participants