You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using environment variables to handle my secrets. I was wondering if it would be ok for me to submit mutator methods to support another means of setting the oauth2.Config's in google.go specifically. I'd of course want to ensure this remains backwards compatible, so I would only be adding these setters. Below are the functions I'd like to add:
// Usage would be something like:google.SetClientID(configs.ClientID)
google.SetClientSecret(configs.ClientSecret)
google.SetRedirectURL(redirectURL)
google.SetScopes([]string{gmail.GmailReadonlyScope})
google.SetEndpoint(google.Endpoint)
If there's no aversion, I'd be happy to submit an PR - with tests too! :)
The text was updated successfully, but these errors were encountered:
I didn't see this listed, so I created an issue and went to the PR's to see what feedback I should be aware of, only to find #53 🤦 - I can close this, or fix their PR, or open a new one. Whatever it takes to get the addition. Thanks!
Sounds good @chrishalbert . You can also do something like WithOptions(o Options) and create all the settings you want to set via the Options struct that you would create.
Whatever you prefer (takeover the PR or recreate).
I'm using environment variables to handle my secrets. I was wondering if it would be ok for me to submit mutator methods to support another means of setting the
oauth2.Config
's in google.go specifically. I'd of course want to ensure this remains backwards compatible, so I would only be adding these setters. Below are the functions I'd like to add:If there's no aversion, I'd be happy to submit an PR - with tests too! :)
The text was updated successfully, but these errors were encountered: