Leased connections are not released

[williamboman]

Description

We're seeing Logbook causing leased connections not to be released. See the following graph, showing the measurement for the Apache client pool (when it recovers is when the instance is rebooted):

Expected Behavior

Leased connections to be released.

Actual Behavior

Leased connections are not released. Eventually the instance runs out of available connections and becomes inoperative.

! org.apache.http.conn.ConnectionPoolTimeoutException: Timeout waiting for connection from pool
! at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.leaseConnection(PoolingHttpClientConnectionManager.java:316)
! at org.apache.http.impl.conn.PoolingHttpClientConnectionManager$1.get(PoolingHttpClientConnectionManager.java:282)
...

Possible Fix

#1052

Steps to Reproduce

Details in #1052.

Context

We are unable to use Logbook due to this which is a bummer because we really like it. It has also caused some unexpected downtime for us.

Your Environment

N/A

[PascalSchumacher]

I guess this can be closed because #1052 was merged.

[williamboman]

Yes!

[williamboman]

Would be awesome with a new release 😉

[whiskeysierra]

I'm preparing 2.10.0 right now. Should be available soon.