Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mention issues with "not-a-bug" label in release notes #1703

Closed
PascalSchumacher opened this issue Dec 4, 2023 · 4 comments
Closed
Labels

Comments

@PascalSchumacher
Copy link
Contributor

PascalSchumacher commented Dec 4, 2023

I think it is potentially confusing for the release notes to contain not-a-bug labeled issues.

E.g.: https://github.com/zalando/logbook/releases/tag/3.7.0 contains #1512 and #1513

These issues have not relation to the release so I think it would be better if there were not mentioned in the release notes.

What do you think?

By the way: Thank you very much for Logbook!

@PascalSchumacher PascalSchumacher changed the title Do not add issues with "not-a-bug" label to release notes Do not mention issues with "not-a-bug" label in release notes Dec 4, 2023
@kasmarian
Copy link
Member

That's a fair point, I agree, it's confusing to see issues, that are just closed

@kasmarian
Copy link
Member

I've updated the last release. We need to start labeling the bug issues, that are not bugs, with invalid or wontfix before closing them. Release script will filter them out. I'll close the issue, as the infrastructure for this is in place, we just need a little bit more discipline around it.

cc @msdousti

@kasmarian
Copy link
Member

kasmarian commented Dec 4, 2023

Just re-read the text and issues, and looks like we could also add the not-a-bug label to the script. I missed that bit initially. Adding it to the script in - #1704

@kasmarian kasmarian reopened this Dec 4, 2023
@PascalSchumacher
Copy link
Contributor Author

Thank you very much! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants