Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Logbook filter order configurable in Spring Boot starter #1835

Open
artemik opened this issue May 13, 2024 · 2 comments
Open

Make Logbook filter order configurable in Spring Boot starter #1835

artemik opened this issue May 13, 2024 · 2 comments

Comments

@artemik
Copy link

artemik commented May 13, 2024

Detailed Description

Make Logbook filter order configurable in Spring Boot starter.

Context

Current Spring Boot starter has hardcoded orders, accordingly to security concerns explained in Logbook docs, for example:

However, it might be beneficial to adjust the order, to accommodate observability related filters, for example.

Possible Implementation

Make the order configurable.

Your Environment

Logbook 3.8.0

@lukasniemeier-zalando
Copy link
Member

Thank you for your idea, I have two (isolated, independent) clarifying questions:

  1. As you are linking to the logbookFilter bean definition, would your use case be solved if you provide your own logbookFilter bean with the desired custom bean order?
  2. If we were to provide configurable bean ordering, would your use case be solved if the order is configurable via the properties (as an integer)?

Copy link
Contributor

In order to prioritize the support for Logbook, we would like to check whether the old issues are still relevant.
This issue has not been updated for over six months.

  • Please check if it is still relevant in latest version of the Logbook.
  • If so, please add a descriptive comment to keep the issue open.
  • Otherwise, the issue will automatically be closed after a week.

@github-actions github-actions bot added the stale label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants