Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate and optimize regular expressions #304

Closed
whiskeysierra opened this issue Jul 4, 2018 · 2 comments
Closed

Re-evaluate and optimize regular expressions #304

whiskeysierra opened this issue Jul 4, 2018 · 2 comments
Assignees
@whiskeysierra @lukasniemeier-zalando
Labels
Discussion Help Wanted
Milestone
2.1.0

Comments

@whiskeysierra
Copy link
Collaborator

Context

After discovering extremely inefficient regular expressions in an internal library, we are now rather careful when using them on arbitrary-length strings.
@whiskeysierra whiskeysierra added this to the 2.1.0 milestone Mar 2, 2019
@whiskeysierra whiskeysierra mentioned this issue Mar 13, 2019
Closed
@whiskeysierra
Copy link
Collaborator Author

💣 Why this is important: https://blog.cloudflare.com/cloudflare-outage/

https://www.regular-expressions.info/catastrophic.html
https://github.com/google/re2/wiki/WhyRE2

@whiskeysierra
Copy link
Collaborator Author

Looks like we ironed some issues with #681, #686 and #689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whiskeysierra whiskeysierra

@lukasniemeier-zalando lukasniemeier-zalando

Labels
Discussion Help Wanted
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@whiskeysierra @lukasniemeier-zalando