Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassNotFoundException: org.zalando.fauxpas.ThrowingConsumer #333

Closed
JanWaller opened this issue Aug 7, 2018 · 4 comments
Closed

ClassNotFoundException: org.zalando.fauxpas.ThrowingConsumer #333

JanWaller opened this issue Aug 7, 2018 · 4 comments

Comments

@JanWaller
Copy link

With a switch to version 1.9 I get a ClassNotFoundException: org.zalando.fauxpas.ThrowingConsumer error, when using LogBook.

compile('org.zalando:logbook-spring-boot-starter:1.9.+')
does not require the org.zalando.fauxpas library

@whiskeysierra
Copy link
Collaborator

@JanWaller
Copy link
Author

JanWaller commented Aug 7, 2018

So, why do i get this error, and if I add it as an explicit dependency, the error is gone?

I checked the jar file logbook-spring-boot-starter-1.9.0.jar
The pom does not include the word faux ...

too hot, indirect dependency...

@JanWaller
Copy link
Author

As a follow up:
This is error is caused by our company mirror of mavencentral:
It gets an error when importing the faux-pas library in version 0.7.1 (0.8.0 works fine):

Could not resolve all dependencies for configuration ':test'.
Could not resolve org.zalando:faux-pas:0.7.1.
Required by:
:PRJ-ImportFromMavenCentralToArtifactory:unspecified
> Could not resolve org.zalando:faux-pas:0.7.1.
> inconsistent module metadata found. Descriptor: org.zalando:faux-pas:0-SNAPSHOT Errors: bad version: expected='0.7.1' found='0-SNAPSHOT'

So, the pom of that library seems to be somewhat inconsistend

@whiskeysierra
Copy link
Collaborator

Ah yes, that's right. For 0.7.1 I tried the release approach described in https://axelfontaine.com/blog/dead-burried.html. As highlighted in the comments, it has the undesired side effect of leaving ${revision} in the pom. You can see it in http://search.maven.org/#artifactdetails%7Corg.zalando%7Cfaux-pas%7C0.7.1%7Cjar:

?xml version="1.0" encoding="UTF-8"?><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
 
    <groupId>org.zalando</groupId>
    <artifactId>faux-pas</artifactId>
    <version>${revision}</version>

0.8.0 or higher doesn't suffer from this, since we reverted the change to the release script.

I added a hint to the release notes for 0.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants