Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide SPI to body embedding #41

Closed
whiskeysierra opened this issue Dec 19, 2015 · 2 comments
Closed

Provide SPI to body embedding #41

whiskeysierra opened this issue Dec 19, 2015 · 2 comments

Comments

@whiskeysierra
Copy link
Collaborator

Right now JSON bodies are embedded directly. Does it make sense to offer extensibility to this via a SPI?
@whiskeysierra whiskeysierra mentioned this issue Dec 19, 2015
Merged
@jhorstmann
Copy link
Contributor

I don't think we need to expose this as an SPI at the moment. If someone wants special formatting it's possible to create a separate implementation of HttpLogFormatter. Our existing implementation is already highly opiniated.

@whiskeysierra
Copy link
Collaborator Author

I guess you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whiskeysierra @jhorstmann