Spring Boot Starter : override bean cause cyclic error

[zsobolsky]

following code causes cyclic error in spring-boot.
Please some help to fix this.

code:

	@Autowired
	public Logbook logbook;

	@Bean
	public RestTemplate restapi() throws Exception {

		CloseableHttpClient httpclient = HttpClientBuilder.create()
			.addInterceptorFirst(new LogbookHttpRequestInterceptor(logbook))
			.addInterceptorFirst(new LogbookHttpResponseInterceptor())
			.build();
		RestTemplate resttemplate = new RestTemplate(new HttpComponentsClientHttpRequestFactory(httpclient));
		return resttemplate;
	} 
	
	@Bean
	public BodyFilter bodyFilter() {
		return BodyFilter.merge(new PrettyPrintingJsonBodyFilter(), BodyFilters.defaultValue());
	}

***************************
APPLICATION FAILED TO START
***************************

Description:

The dependencies of some of the beans in the application context form a cycle:

   secureLogbookFilter defined in class path resource [org/zalando/logbook/autoconfigure/LogbookAutoConfiguration$SecurityServletFilterConfiguration.class]
+-----+
|  logbook defined in class path resource [org/zalando/logbook/autoconfigure/LogbookAutoConfiguration.class]
?     ?
|  restAPIConfig (field public org.zalando.logbook.Logbook com.restapi.jconfig.RestAPIConfig.logbook)
+-----+

When commenting
@Autowired public Logbook logbook
or
@bean public BodyFilter bodyFilter() {},
the problem issue is gone.

[whiskeysierra]

Your configuration both depends on Logbook but also provides a part of its configuration. Two options:

1. Split up your configuration into two different ones.
2. Make logbook a parameter of the restapi method, rather than an instance field, like so:

@Bean
public RestTemplate restapi(final Logbook logbook) throws Exception {
	CloseableHttpClient httpclient = HttpClientBuilder.create()
		.addInterceptorFirst(new LogbookHttpRequestInterceptor(logbook))
		.addInterceptorFirst(new LogbookHttpResponseInterceptor())
		.build();
	return new RestTemplate(new HttpComponentsClientHttpRequestFactory(httpclient));
} 

[zsobolsky]

issue is fixed with 2nd option