Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Uniform Layout and Naming of Hints, Remarks, Exceptions etc. #660

Open
tfrauenstein opened this issue May 18, 2021 · 11 comments
Open

Comments

@tfrauenstein
Copy link
Member

tfrauenstein commented May 18, 2021

We use different layout formats for standard guideline elements like 'Exception:', 'Hint:', 'Note:', 'Remark:', 'Example:', 'Tip', 'Reasoning:', 'Warning:', 'Important:', 'Caution:'. Additionally, the elements are partially redundant with unclear 'didactic purpose'.
Let us reduce the elements to a minimal set with clear purpose and uniform layout.
It will contribute to readability and efficient consumption by API builders. Examples:

@vadeg
Copy link
Contributor

vadeg commented May 19, 2021

I propose to use several features provided by Asciidoc for formatting:

  1. Admonitions for hints, exceptions and etc.
  2. Sidebars to highlight a block of text.

@ePaul
Copy link
Member

ePaul commented Jun 1, 2021

From the meeting:

  • We agree that unifying this is useful
  • @vadeg will add a proposal on how to do this (like 3-4 different things)

@vadeg
Copy link
Contributor

vadeg commented Jul 1, 2021

I have collected a number of occurrences of different elements and mapped them to possible replacements from AsciiDoctor

Current element Occurrences AsciiDoctor Admonition element
Hint 32 TIP or NOTE
Example 10 Implement new EXAMPLE admonition ( An example how to do this. Or keep it as of now )
Note 47 NOTE
TIP 1 TIP
Reasoning 1 NOTE
Exception 7 IMPORTANT
Warning 1 WARNING

@tfrauenstein
Copy link
Member Author

Thx for the progress here -- looks good. Remarks:
a) Let us provide a short definition of when to use TIP vs. NOTE when mapped from Hint
b) The only 1 Warning is more a Note
c) Let us stick to use Exception (create new new admonition) -- it is important for a guideline rule framework.

@ePaul

This comment was marked as outdated.

@tkrop
Copy link
Member

tkrop commented Dec 7, 2021

It may also make sense to realign on how to emphasize keywords like MUST, SHOULD, RECOMMENDED, etc. In text we currently use must, should, ... - also often forgetting the bold, while we use MUST, SHOULD, ... in the rule titles. I think we should strive for consistency here too - especially since we refer to RFC2119 in the Conventions Section. See also #693.

@ePaul
Copy link
Member

ePaul commented Mar 22, 2022

@vadeg do you expect you can get to this in the near future?

@vadeg
Copy link
Contributor

vadeg commented Mar 27, 2022

@ePaul yes. I am testing the UI for asciidoc. Current schema doesn't support properly some formatting components.

@vadeg
Copy link
Contributor

vadeg commented May 27, 2022

@tfrauenstein

a) Let us provide a short definition of when to use TIP vs. NOTE when mapped from Hint

Do you suggest to provide it somewhere in the document? If you have any guidance what should be the note and what should be the tip I would like to have it before making changes.

@tfrauenstein
Copy link
Member Author

@vadeg I do not yet have a specific guidance, and propose that we should proceed only with 'note'. If it turns out that some hints are better handled as 'note', then we can use it and define the criteria. I would not overload the doc with a definition -- it should be clear from context.

@ePaul ePaul unassigned vadeg Mar 21, 2023
@ePaul
Copy link
Member

ePaul commented Mar 21, 2023

We agreed that this is still worth doing, but currently nobody has time.
Approach:

  1. consistently use the existing annotations where they fit.
  2. use the examples from Document how to create a new admonition type asciidoctor/asciidoctor-extensions-lab#9 to implement new annotations for exception + example, then use them.

Volunteers are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants