Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g_init #7

Open
mse0 opened this issue Jun 3, 2020 · 1 comment
Open

g_init #7

mse0 opened this issue Jun 3, 2020 · 1 comment

Comments

@mse0
Copy link

mse0 commented Jun 3, 2020

I was wondering why the MLP parameters are all initialized to mean 1? (The paper says mean 0)

Also why are there two "bands" for each periodic dimension? The paper says the final MLP bias is initialized using N(c, 0.02c) where c \in (0,pi], but the code uses the two bands and initializes 0 and 1 for x and y frequencies respectively (for band 1), and vice versa for band 2.

Thanks

@ubergmann
Copy link
Collaborator

Good catch - probably should be w_init instead of g_init! Might've been changed when we published the code (from the internal version). I'll check in the next week or so if this has significant impact.

Also: check-out the pytorch version that is linked in the Readme.md! Lasagne is outdated - in our team nobody uses it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants