Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Diff monitor #97

Closed
zalmoxisus opened this issue Apr 23, 2016 · 5 comments
Closed

Remove Diff monitor #97

zalmoxisus opened this issue Apr 23, 2016 · 5 comments

Comments

@zalmoxisus
Copy link
Owner

Are there any advantages of using Diff Monitor since we now have Diff functionality in the Inspector Monitor?

There are some issues there solved by @jhen0409, but not sure how maintained the project is. To support it in future we'll also need to support theming there as suggested in #96.

@Koleok
Copy link

Koleok commented Apr 25, 2016

I don't think the diff monitor has enough to offer to really justify itself in light of the inspector

@jhen0409
Copy link
Collaborator

The Inspector has not yet implement some features, like alexkuz/redux-devtools-inspector#19 alexkuz/redux-devtools-inspector#20.

But I agree removing Diff monitor, I don't know they whether or not to continue to maintain project, if they don't fix these problems, it's not conducive to self-build for extension.

@zalmoxisus
Copy link
Owner Author

zalmoxisus commented Apr 25, 2016

@jhen0409, while these features are present in the Log Monitor, that's not a problem. We want to have multiple monitors, each of them should be focused on solving specific problems.

@alexkuz
Copy link
Contributor

alexkuz commented Apr 30, 2016

Inspector now supports skipping and committing actions.

@zalmoxisus
Copy link
Owner Author

Removed in v1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants