fix: propagate GLWE config on hybrid MLP unit test #928
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @alinealfa on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Signed-off-by: Aline Almeida <aline@io.net>
alinealfa
force-pushed
the
fix/927_propagate_glwe_config_on_test_hybrid_mlp
branch
from
e27c7db
to
b0133da
Compare
|
Thanks @andrei-stoian-zama. I updated the commit as the CI was enforcing signature. |
|
@alinealfa , as we require signed commits only from approved Zama employees, I needed to re-base your PR . It's here: #935 and I'll close this one. |
Got it. So should external contributors not sign the commit? Actually the Contributing doc does not indicate need of signature. I ended up adding so we could get the CI/tests unblocked. |
Notes
Fix #927 - Address
test_hybrid_converter.pyfailure on MacOSThis fix propagates the GLWE configuration in the hybrid MLP unit test.
Review needed to confirm if this aligns with the test's original intended behavior.
Testing
Executed the
maketasks as outlined in contributing.md. For pytest, used pytest_no_flaky due to a local unrelatedtest_brevitas_qat.pytest failure, which is known to be flaky.