Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issues on C++20 (around constructor syntax of templated structs) #1124

Open
ddevienne opened this issue Jan 31, 2024 · 1 comment
Open

Comments

@ddevienne
Copy link

We are advancing our internal stack to GCC12 and MSVC2022 on C++20, and this breaks WebSocketPP (perhaps because of warning-as-error, I'm not the prime mover here, just the one taking the time to report it).

The colleague that did the port used jcelerier@3e761b5 from https://github.com/jcelerier/websocketpp/tree/develop. But personally I'd prefer the official project to have that fix and a new release. I also see a C++23 deprecation in the open issues as well, which could be part of said minor maintenance release to keep up with newer (stricter?) compilers. WDYT?

@rerdavies
Copy link

The "develop" branch has compatibility fixes for C++20. No idea what the state of the "develop" branch is. fwiw, it is 69 commits ahead of the main branch, so somebody has done a lot of work on it (and fixed a LOT of bugs).. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants