Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrated] Discussion: A new testing library #459

Closed
jneves opened this issue Feb 20, 2021 · 1 comment
Closed

[Migrated] Discussion: A new testing library #459

jneves opened this issue Feb 20, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists feature-request Request/idea regarding new and/or improved functionality good-idea

Comments

@jneves
Copy link
Contributor

jneves commented Feb 20, 2021

Originally from: Miserlou/Zappa#1224 by bxm156

Obviously there are many issues on this project that are also a high priority, but I was hoping to have some discussion on the future of tests/testing in Zappa. My hope is that this initial discussion will help establish a direction and preferred testing library for new tests (and eventually migrating existing ones).

From http://nose.readthedocs.io/en/latest/:

Nose has been in maintenance mode for the past several years and will likely cease without a new person/team to take over maintainership. New projects should consider using Nose2, py.test, or just plain unittest/unittest2.

As Zappa grows, the current tests are going to need to be refactored. I think when new tests are written and old/existing ones are updated, it may be worth converting them to a newer, maintained testing library. The tests are currently all in a few large files, and they are not organized very well. There are also very large constructs to mimic api gateway data that make navigating these files annoying. In short, ```tests/```` definitely could use some love ❤️.

I personally use tox + py.test at both home and work, which I have come to really enjoy. py.test is very pythonic, supports dependency injection, test parameterization, is easily configurable, and supports plugins.

Using tox for testing relates somewhat to #813

@jneves jneves added feature-request Request/idea regarding new and/or improved functionality good-idea testing labels Feb 20, 2021
@monkut monkut added the duplicate This issue or pull request already exists label Aug 18, 2022
@monkut
Copy link
Collaborator

monkut commented Aug 18, 2022

marking as duplicate of:
#1146

closing.

@monkut monkut closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists feature-request Request/idea regarding new and/or improved functionality good-idea
Projects
None yet
Development

No branches or pull requests

2 participants