Fix download via popup on Edge

Fixes: #208

Signed-off-by: Simon Bennetts <psiinon@gmail.com>

Author: psiinon

CHANGELOG.md

@@ -8,6 +8,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Fixed
 - Download on script completion on Chrome.
 - Download file date string.
+- Download via popup on Edge.
+- Close notification dialog when script downloaded directly.
 
 ## 0.1.2 - 2025-06-17
 

CHANGELOG.rec.md

@@ -8,6 +8,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Fixed
 - Download on script completion on Chrome.
 - Download file date string.
+- Download via popup on Edge.
+- Close notification dialog when script downloaded directly.
 
 ## 0.1.2 - 2025-06-17
 

source/Background/index.ts

@@ -30,7 +30,6 @@ import {
   REPORT_OBJECT,
   RESET_ZEST_SCRIPT,
   SESSION_STORAGE,
-  SET_SAVE_SCRIPT_ENABLE,
   STOP_RECORDING,
   ZEST_SCRIPT,
 } from '../utils/constants';
@@ -249,11 +248,6 @@ async function handleMessage(
       }
       break;
     }
-    case SET_SAVE_SCRIPT_ENABLE:
-      Browser.storage.sync.set({
-        zapenablesavescript: zestScript.getZestStatementCount() > 0,
-      });
-      break;
 
     default:
       // Handle unknown request type

source/Popup/index.tsx

@@ -25,7 +25,6 @@ import {
   GET_ZEST_SCRIPT,
   IS_FULL_EXTENSION,
   RESET_ZEST_SCRIPT,
-  SET_SAVE_SCRIPT_ENABLE,
   STOP_RECORDING,
   UPDATE_TITLE,
   ZAP_START_RECORDING,
@@ -90,14 +89,12 @@ function startedAnimation(): void {
 
 async function restoreState(): Promise<void> {
   console.log('Restore state');
-  await Browser.runtime.sendMessage({type: SET_SAVE_SCRIPT_ENABLE});
   optionsIcon.title = OPTIONS;
   downloadIcon.title = DOWNLOAD;
   Browser.storage.sync
     .get({
       zaprecordingactive: false,
       zapscriptname: '',
-      zapenablesavescript: false,
     })
     .then((items) => {
       if (items.zaprecordingactive) {
@@ -111,11 +108,6 @@ async function restoreState(): Promise<void> {
       } else {
         done?.classList.add('invisible');
       }
-      if (!items.zapenablesavescript) {
-        saveScriptButton.classList.add('disabled');
-      } else {
-        saveScriptButton.classList.remove('disabled');
-      }
     });
 }
 
@@ -149,7 +141,9 @@ function startRecording(): void {
 }
 
 function toggleRecording(e: Event): void {
+  console.log('ZAP toggleRecording');
   e.preventDefault();
+  saveScriptButton.classList.remove('disabled');
   Browser.storage.sync.get({zaprecordingactive: false}).then((items) => {
     if (items.zaprecordingactive) {
       stopRecording();
@@ -189,7 +183,14 @@ function openHelpPage(): void {
   closePopup();
 }
 
-function downloadZestScript(zestScriptJSON: string, title: string): void {
+function downloadZestScript(
+  zestScriptJSON: string,
+  title: string,
+  statementCount: number
+): void {
+  if (statementCount === 0) {
+    return;
+  }
   if (title === '') {
     scriptNameInput?.focus();
     return;
@@ -211,11 +212,12 @@ async function handleSaveScript(): Promise<void> {
     zaprecordingactive: false,
   });
   if (storageItems.zaprecordingactive) {
+    sendMessageToContentScript(ZAP_STOP_RECORDING);
     await Browser.runtime.sendMessage({type: STOP_RECORDING});
   }
   Browser.runtime.sendMessage({type: GET_ZEST_SCRIPT}).then((items) => {
     const msg = items as ZestScriptMessage;
-    downloadZestScript(msg.script, msg.title);
+    downloadZestScript(msg.script, msg.title, msg.statementCount);
   });
 }
 

source/types/zestScript/ZestScript.ts

@@ -22,6 +22,7 @@ import Browser from 'webextension-polyfill';
 interface ZestScriptMessage {
   script: string;
   title: string;
+  statementCount: number;
 }
 
 class ZestScript {
@@ -93,7 +94,11 @@ class ZestScript {
     return new Promise((resolve) => {
       Browser.storage.sync.get({zapscriptname: this.title}).then((items) => {
         this.title = items.zapscriptname as string;
-        resolve({script: this.toJSON(), title: this.title});
+        resolve({
+          script: this.toJSON(),
+          title: this.title,
+          statementCount: this.getZestStatementCount(),
+        });
       });
     });
   }

source/utils/constants.ts

@@ -38,7 +38,6 @@ export const DEFAULT_WINDOW_HANDLE = 'windowHandle1';
 
 export const ZAP_STOP_RECORDING = 'zapStopRecording';
 export const ZAP_START_RECORDING = 'zapStartRecording';
-export const SET_SAVE_SCRIPT_ENABLE = 'setSaveScriptEnable';
 export const ZEST_SCRIPT = 'zestScript';
 
 export const STOP_RECORDING = 'stopRecording';