Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports: CX Rebrand #5764

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Reports: CX Rebrand #5764

merged 1 commit into from
Sep 26, 2024

Conversation

psiinon
Copy link
Member

@psiinon psiinon commented Sep 25, 2024

Overview

Some of the reports could look better, but we can tweak them as required in the future.

Related Issues

N/A

Checklist

  • [na] Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@psiinon
Copy link
Member Author

psiinon commented Sep 25, 2024

Oops, will fix the formatting..

Comment on lines +47 to +48
th:class="'text-right'">ZAP Version</em> <em> ZAP by <a
href="https://checkmarx.com/">Checkmarx</a>
Copy link
Member

@kingthorin kingthorin Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's a missing space between a and href, hence the failure, but I'm not sure how you sort that out with the formatter.

Some of the reports could look better, but we can tweak them as required
in the future.

Signed-off-by: Simon Bennetts <psiinon@gmail.com>
@thc202 thc202 merged commit 46e63af into zaproxy:main Sep 26, 2024
10 checks passed
@thc202
Copy link
Member

thc202 commented Sep 26, 2024

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants