Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lab mr create does not work when the editor takes arguments #747

Closed
BrainBlasted opened this issue Oct 5, 2021 · 3 comments · Fixed by #748
Closed

lab mr create does not work when the editor takes arguments #747

BrainBlasted opened this issue Oct 5, 2021 · 3 comments · Fixed by #748
Assignees
@bmeneg

Comments

@BrainBlasted
Copy link
Contributor

I have core.editor set to flatpak run --file-forwarding re.sonny.Commit @@ - this opens Commit in a new window, and it doesn't need to be installed on the host. This works fine for git commit, but lab parses the arguments after flatpak as one big argument:

error: 'run --file-forwarding re.sonny.Commit @@' is not a flatpak command. Did you mean 'build-commit-from'?

See 'flatpak --help'
2021/10/04 17:43:47 mr_create.go:180: /home/chris/Projects/lab/cmd/mr_create.go:179 exit status 1
@bmeneg bmeneg self-assigned this Oct 5, 2021
@bmeneg
Copy link
Collaborator

bmeneg commented Oct 5, 2021

Oh, thanks for the report! I'm going to look into it.

@bmeneg bmeneg mentioned this issue Oct 5, 2021
Merged
@bmeneg
Copy link
Collaborator

bmeneg commented Oct 5, 2021

@BrainBlasted as soon as #748 is merged your issue should be fixed.

@BrainBlasted
Copy link
Contributor Author

Awesome - thanks for the fast response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmeneg bmeneg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

git: fix edit command when using extra args bmeneg/lab
2 participants
@bmeneg @BrainBlasted