Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lab 0.23.0: `mr show -c' fails in git worktree #773

Closed
github-cygwin opened this issue Dec 20, 2021 · 1 comment · Fixed by #775
Closed

lab 0.23.0: `mr show -c' fails in git worktree #773

github-cygwin opened this issue Dec 20, 2021 · 1 comment · Fixed by #775
Assignees

Comments

@github-cygwin
Copy link

github-cygwin commented Dec 20, 2021

Hi,

I just encountered the issue from the subject line. While
lab mr show <MR#>
works nicely in a worktree,
lab mr show -c <MR#>
fails with ERROR: config.go:364: open .git/lab/lab.toml: not a directory
The reason is apparently that .git is a file in a worktree, rather than a directory. Looks like following the gitdir info in the worktree .git file is not implemented yet?

Corinna

@bmeneg
Copy link
Collaborator

bmeneg commented Jan 5, 2022

Hi Corinna,

We already have the code for following the gitdir, but it isn't being used where it should.
I'm going to submit a PR correcting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants