-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commentChar=auto not supported #8
Comments
the issue has been resolved in hub, check out the changeset here: mislav/hub#1660 |
Considering the way |
I wouldn't be surprised if this is still an issue. That said I think the bigger/more important update to make is #334 |
Hi, I have come across this issues as I am using commentChar=; and have noticed that it adversely affects writing notes.
This is because https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L182 uses commentChar, while https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L114 and https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L126 use # The result is that I have to delete one of the lines in the editor, if my commentChar is not set to #, or that line will appear in the comment. If commentChar=auto I suspect I'd have to delete both lines, although I haven't tested that to confirm it. |
mislav/hub#1512 is definitely also an issue in lab.
The text was updated successfully, but these errors were encountered: