Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commentChar=auto not supported #8

Open
zaquestion opened this issue Sep 7, 2017 · 4 comments
Open

commentChar=auto not supported #8

zaquestion opened this issue Sep 7, 2017 · 4 comments

Comments

@zaquestion
Copy link
Owner

mislav/hub#1512 is definitely also an issue in lab.

@mareksuscak
Copy link

the issue has been resolved in hub, check out the changeset here: mislav/hub#1660

@bmeneg
Copy link
Collaborator

bmeneg commented Jun 15, 2021

Considering the way lab works today, I'm kinda skeptical it's still a problem for us.
@zaquestion any thoughts? I'm inclined to close it.

@zaquestion
Copy link
Owner Author

I wouldn't be surprised if this is still an issue. That said I think the bigger/more important update to make is #334

@simonbrent
Copy link

Hi, I have come across this issues as I am using commentChar=; and have noticed that it adversely affects writing notes.
lab issue 123 note opens an editor with the following content:

                                                                  
# This comment is being applied to OPEN Issue 1040.               
; Write a message for this note. Commented lines are discarded.

This is because https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L182 uses commentChar, while https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L114 and https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L126 use #

The result is that I have to delete one of the lines in the editor, if my commentChar is not set to #, or that line will appear in the comment. If commentChar=auto I suspect I'd have to delete both lines, although I haven't tested that to confirm it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants