Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible infinite loops with context timeout #2508

Open
phillebaba opened this issue May 15, 2024 · 0 comments
Open

Fix possible infinite loops with context timeout #2508

phillebaba opened this issue May 15, 2024 · 0 comments
Labels
tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@phillebaba
Copy link
Member

Describe what should be investigated or refactored

The addition of contexts in #2405 fixed some issues with possible infinite loops using contexts. That got me thinking if there are any other examples that are out of scope for that PR. I found two cases that should be fixed.

Links to any relevant code

https://github.com/defenseunicorns/zarf/blob/48c11d99547b59ff2f10fa60078741376059f821/src/pkg/cluster/data.go#L58
https://github.com/defenseunicorns/zarf/blob/48c11d99547b59ff2f10fa60078741376059f821/src/pkg/utils/bytes.go#L67

Additional context

N/A
@phillebaba phillebaba added the tech-debt 💳 Debt that the team has charged and needs to repay label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Zarf
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillebaba