Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several functions in Zarf need to be more context aware and return an error after context is cancelled #2647

Open
4 tasks
AustinAbro321 opened this issue Jun 20, 2024 · 0 comments
Labels
enhancement ✨ New feature or request

Comments

@AustinAbro321
Copy link
Contributor

AustinAbro321 commented Jun 20, 2024

With the recent change in #2567 which changed Zarf to cancel context instead of running os.exit(1) after the first SIGINT, we need to change functions to use context and return an err up all the way up the stack when context is cancelled.

Note: A second sigint will always `os.exit(1)

The following is a list of functionality that needs context, but there are likely several more:

  • File downloads on create
  • During data injections on deploy
  • Image pull on create - this cannot be properly fixed until we switch from using crane, perhaps to ORAS which implements context, or crane implements context
  • helm install / upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: Triage
Development

No branches or pull requests

1 participant