-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jenkin's lookup3 as a 32-bit checksum for HDF5 #445
Comments
Would the best route be to use cython as @martindurant did in #412 for fletcher32 or would it make sense to add jenkins-cffi as a dependency https://github.com/what-studio/jenkins-cffi/ ? |
We tend to favor either vendoring outside libraries or reimplementing algorithms in Cython. (Numcodecs has no dependencies other than numpy.) Both options seem plausible here. I'd go for the path of least resistance. @mkitti - are you interested in working on PR to add this codec? We will be glad to support you. |
Minimal, reproducible code sample, a copy-pastable example if possible
Problem description
Jenkin's lookup3 is an integral component of the HDF5 specification for its internal datastructures.
This becomes relevant if we would like to reuse HDF5 data structures. For example, the HDF5 Fixed Array Data Block can made byte compatible with the proposed Zarr shard specification, except for the four byte checksum. Currently, the only permitted checksum is crc32.
zarr-developers/zarr-specs#152 (comment)
An implementation of Bob Jenkin's lookup3 is widely available across many languages.
Version and installation information
Please provide the following:
The text was updated successfully, but these errors were encountered: