Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resizing to spec #188

Closed
jakirkham opened this issue Nov 30, 2022 · 1 comment · Fixed by #208
Closed

Adding resizing to spec #188

jakirkham opened this issue Nov 30, 2022 · 1 comment · Fixed by #208
Assignees
Labels
core-protocol-v3.0 Issue relates to the core protocol version 3.0 spec v2

Comments

@jakirkham
Copy link
Member

jakirkham commented Nov 30, 2022

Currently zarr-python has the ability to resize (through a metadata change) arrays with no guarantee about how the underlying data changes. This is currently not in either v2 or v3 spec. Would be good to make this clearer.

cc @joshmoore @DennisHeimbigner @jstriebel

@jstriebel jstriebel added v2 core-protocol-v3.0 Issue relates to the core protocol version 3.0 spec labels Dec 5, 2022
@jstriebel jstriebel added this to ZEP1 Dec 5, 2022
@jstriebel jstriebel moved this to Needs PR in ZEP1 Dec 5, 2022
@jstriebel
Copy link
Member

I agree, we should add a note about that in v3. I'd propose to add something similar to:

  • resizing is possible
  • shrinking: Implementations can consider to delete chunks if the store allows this, or keep them. This should be communicated well to the user.
  • increasing: If no data existed previously for the new areas, they implicitly have the fill value now. Previous partial chunks will contain the fill value at the time of writing them. If there was chunk data before for the new areas, this data will be shown. The latter case should be signalled to the user appropriately.

cc @DennisHeimbigner @jbms

@jstriebel jstriebel self-assigned this Feb 16, 2023
@jstriebel jstriebel moved this from Needs PR to In Review in ZEP1 Feb 16, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in ZEP1 Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol-v3.0 Issue relates to the core protocol version 3.0 spec v2
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants