Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-less version #7

Open
asyschikov opened this issue May 29, 2016 · 2 comments
Open

JSON-less version #7

asyschikov opened this issue May 29, 2016 · 2 comments

Comments

@asyschikov
Copy link

asyschikov commented May 29, 2016

I really like your lib but I am not very enthusiastic about Newtonsoft.JSON dependency because I don't need it and I don't want to add extra 500k to my app. Any chance to make it optional?

@stephanpalmer
Copy link
Contributor

Hi, we can understand the reluctance to have an unneeded Newtonsoft.Json dependency. We hesitated to package it like this, but in the end it was just the simplest way for us to package the needed features.

Unfortunately, we currently cannot devote any time to update SimpleStorage. However, it should be fairly easy to fork SimpleStorage and remove the Newtonsoft.Json dependency. For this, just remove the class JsonPersistingList, and remove the dependency from SimpleStorage.nuspec.

Alternatively, as long as you do not use JsonPersistingList, you could change the linking behaviour of the app to "Link All". The Newtonsoft.Json dll should then be stripped out of the app bundle. However, this could very well introduce problems with other libs or your own dlls.

@asyschikov
Copy link
Author

Thanks, I will try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants