Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "frozen" model concept with "owner" #103

Open
zbanks opened this issue Jul 29, 2019 · 0 comments
Open

Replace "frozen" model concept with "owner" #103

zbanks opened this issue Jul 29, 2019 · 0 comments
Assignees

Comments

@zbanks
Copy link
Owner

zbanks commented Jul 29, 2019

#98 was a half-baked attempt at implementing "frozen" nodes & edges in the model, so that the user couldn't mess with the nodes that AutoDJ was also trying to manipulate.

Problems/rationale:

  • It's buggy. Freezing parameters still lets you change the slider but it isn't connected. (Unfreezing parameters doesn't work?)
  • "Frozen input" & "frozen output" shouldn't be node properties: the edges themselves should be frozen. We can assume it doesn't make sense to freeze an empty input/output.
  • For the physical controller I'm working on, that will also want to freeze nodes & edges so the user cannot change the graph from the UI (they have to use the physical controller). This is separate from the AutoDJ.

Fix:

  • Remove frozenOutput/frozenInput from VideoNode; replace them with an owner of the Edge in the Model.
    • Owner is a string identifier, right now either "ui" or "autodj".
  • Replace frozenParameters from VideoNode with owner
  • All Model-modifying actions take an optional owner, and only modify nodes/edges with matching owner. Creating new nodes/edges sets the given owner.
@zbanks zbanks self-assigned this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant