Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll: Virtual Text and Show In Buffer #19

Closed
zbirenbaum opened this issue Apr 13, 2022 · 1 comment
Closed

Poll: Virtual Text and Show In Buffer #19

zbirenbaum opened this issue Apr 13, 2022 · 1 comment

Comments

@zbirenbaum
Copy link
Owner

zbirenbaum commented Apr 13, 2022

So alongside working on the api, the way I have been testing it is by implementing the features inside of copilot.vim, including making a constant request loop with configurable polling time and handlers.

Virtual text needs a bit more work, but I have it very close to exactly the same experience you would have working on copilot.vim.

Showing results in a dedicated buffer is something I developed as a debugging tool, but it would be very simple to include. It would also be simple to make this a floating window.

Once, these are fully done, all that would be left to have copilot.vim's experience fully implemented are a couple of small features here and there, and authentication through my plugin rather than generating the json file with copilot.vim

My question is as follows: Would you, as users, like the completion buffer and vtext to be included in the core repository, or, would you like to have ONLY the event loop api and required hooks for creating such a handler yourself in the core repo, and include examples on how to use the api to implement handlers such as the ones mentioned inside of the documentation.

Currently, I am leaning towards keeping them in the docs, as it would keep the source cleaner, but I am not sure how heavy the desire for these features are so I figured it would be best to ask. If enough people want it out of the box, I'm happy to include it.

As a side note: While this work is being accomplished in development branches available on github, I would discourage anyone from trying to use them currently, as they are still quite buggy, and the api is subject to change once I have everything done and can plan out the exact structure of all necessary hooks.

If you would like to assist in their development, feel free to offer input or PR, but don't be offended if I don't merge it, as pretty much every aspect of the api is subject to change until I think it's ready to go on the main branch.

Vote 👍 to include them, and 👎 to make them part of the documentation

@zbirenbaum zbirenbaum pinned this issue Apr 13, 2022
@zbirenbaum zbirenbaum changed the title Poll: Virtual Text and Show in buffer Poll: Virtual Text and Show In Buffer Apr 13, 2022
@zbirenbaum zbirenbaum unpinned this issue Sep 9, 2022
@zbirenbaum
Copy link
Owner Author

As of #53 and #50 both have been implemented in panel.lua and suggestion.lua. Thanks so much @MunifTanjim for the incredible work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant