MSM optimizations #608
Merged
MSM optimizations #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
daira
approved these changes
Jun 22, 2022
…ests. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Reduce memory overhead of MSM
daira
reviewed
Jun 23, 2022
| bases.extend( | ||
| self.other | ||
| .iter() | ||
| .map(|(x, (_, y))| C::from_xy(*x, *y).unwrap()), |
There was a problem hiding this comment.
See ebfull#1 (comment) for performance analysis of doing this vs storing x-coordinate -> (scalar, point).
str4d
approved these changes
Jun 23, 2022
Comment on lines
+39
to
+49
| self.other | ||
| .entry(*x) | ||
| .and_modify(|(our_scalar, our_y)| { | ||
| if our_y == y { | ||
| *our_scalar += *scalar; | ||
| } else { | ||
| assert!(*our_y == -*y); | ||
| *our_scalar -= *scalar; | ||
| } | ||
| }) | ||
| .or_insert((*scalar, *y)); |
There was a problem hiding this comment.
Non-blocking: this could be de-duplicated from add_msm and append_term with a helper method.
There was a problem hiding this comment.
Yes, I couldn't quite get that to work, so deferred it for a later cleanup.
str4d
added a commit
that referenced
this pull request
Jun 23, 2022
`BatchVerifier` now manages the entire batch verification process. Individual proofs are verified on a threadpool, and the resulting MSMs are then batch-checked as before. The addition of parallelism here couples with #608 to make parallelism less fine-grained and reduce the overhead of multi-threading.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parallelizecalls from inside the MSM when operating on scalars, which has enormous overhead even for relatively large circuits.MSMto deduplicate group elements #606)