Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests? #49

Closed
mirkoAlic opened this issue Nov 28, 2018 · 2 comments
Closed

Missing tests? #49

mirkoAlic opened this issue Nov 28, 2018 · 2 comments
Labels

Comments

@mirkoAlic
Copy link

I'm trying to do a JNR wrapper of the library, and i can't find unit tests for methods like: librustzcash_sapling_check_spend, librustzcash_sapling_binding_sig, etc. It is in your future plans to add them?

@str4d str4d added the question label Jan 15, 2019
@str4d
Copy link
Contributor

str4d commented Jan 15, 2019

Eventually yes. These various methods are FFIs intended for consumption by zcashd, so currently tests of them tend to be in the zcashd codebase. What we intend to do as part of #41 is refactor the logic out of the FFI functions to create a pure-Rust API, which can be tested on its own.

The particular methods you refer to have now been refactored into the zcash_proofs crate in #30. The next step would be writing tests for them, which will require adding a test params harness (since the test runner may not have the production parameters available). I'll open new issues for this and similar components.

@str4d
Copy link
Contributor

str4d commented Jan 15, 2019

I've opened zcash/sapling-crypto#145 and #57 covering the two parts of this question.

@str4d str4d closed this as completed Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants