Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ZIP 307 (light client protocol) with ZIP 212 changes #380

Closed
daira opened this issue Jun 29, 2020 · 2 comments
Closed

Update ZIP 307 (light client protocol) with ZIP 212 changes #380

daira opened this issue Jun 29, 2020 · 2 comments
Assignees
@daira
Labels
S-committed Status: Planned work in a sprint ZIP bug
Milestone
Core Sprint 2020-41

Comments

@daira
Copy link
Collaborator

daira commented Jun 29, 2020 •
edited
Loading

Make ZIP 307 match zcash/librustzcash#286 and be consistent with ZIP 212.
@r3ld3v r3ld3v added this to the Core Sprint 2020-25 milestone Jun 29, 2020
@daira daira self-assigned this Jun 29, 2020
@daira daira mentioned this issue Jul 1, 2020
Closed
@daira daira added the ZIP bug label Jul 1, 2020
@daira
Copy link
Collaborator Author

daira commented Sep 9, 2020

Also mention this issue:

The light client can't check integrity of the first byte of the memo. In particular the light wallet server could XOR that first byte with any other byte value. It can check the note commitment, but not the memo, unless it has all of the ciphertext. ZIP 307 doesn't explicitly say that, which is a bug.

@str4d str4d added the S-committed Status: Planned work in a sprint label Oct 12, 2020
@daira
Copy link
Collaborator Author

daira commented Oct 19, 2020

Fixed in e63f046 . The implementation in zcash/librustzcash#286 already matched the intended spec.

@daira daira closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daira daira

Labels
S-committed Status: Planned work in a sprint ZIP bug
Projects
None yet
Milestone
Core Sprint 2020-41
Development

No branches or pull requests
3 participants
@daira @str4d @r3ld3v