Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Protocol spec] JoinSplit balance should not be a consensus rule #582

Closed
daira opened this issue Jan 18, 2022 · 1 comment
Closed

[Protocol spec] JoinSplit balance should not be a consensus rule #582

daira opened this issue Jan 18, 2022 · 1 comment
Assignees
@daira
Labels
consensus Consensus changes, and errors or omissions in consensus specification protocol spec S-committed Status: Planned work in a sprint
Milestone
Release 4.7.0

Comments

@daira
Copy link
Collaborator

daira commented Jan 18, 2022

JoinSplit balance is enforced by the JoinSplit statement, but also specified as a consensus rule in Section 3.5 JoinSplit Transfers and Descriptions. The latter should not be a consensus rule, since it is not something that nodes can check directly. Thanks to @upbqdn for spotting this.
@daira daira added this to the Core Sprint 2022-02 milestone Jan 18, 2022
@daira daira self-assigned this Jan 18, 2022
@daira daira added the consensus Consensus changes, and errors or omissions in consensus specification label Jan 18, 2022
@upbqdn upbqdn mentioned this issue Jan 18, 2022
Merged
3 tasks
@r3ld3v r3ld3v added the S-committed Status: Planned work in a sprint label Feb 25, 2022
@r3ld3v r3ld3v added S-committed Status: Planned work in a sprint and removed S-committed Status: Planned work in a sprint labels Mar 15, 2022
@daira
Copy link
Collaborator Author

daira commented Mar 17, 2022

This was fixed in 2022.2.19 (0cdab50).

@daira daira closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daira daira

Labels
consensus Consensus changes, and errors or omissions in consensus specification protocol spec S-committed Status: Planned work in a sprint
Projects
None yet
Milestone
Release 4.7.0
Development

No branches or pull requests
2 participants
@daira @r3ld3v