Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change name or revision number of your fork #15

Open
asqwerth opened this issue Mar 10, 2020 · 5 comments
Open

change name or revision number of your fork #15

asqwerth opened this issue Mar 10, 2020 · 5 comments
Assignees

Comments

@asqwerth
Copy link

Hi, I made a request of the MX Linux packaging team to package your fork of CM for trial and assessment, since it is stated to be able to detect new-syntax conky configs, which the original CM doesn't.

The packaging team have asked if it is possible for you to rename your fork or give it a different revision number, presumably so that it does not clash with CM or try to write over it. CM is installed by default in MX installs and I believe the MX-app called "MX-Conky" may depend on it.

If possible, I would like to run both CM and CM2 side by side, and compare the 2.

Thanks!

@zcot
Copy link
Owner

zcot commented Mar 30, 2020

@asqwerth,

Check it out(clone) for yourself.

The name is changed.

The revision number is changed.

The binary is changed.

You can run both side by side.

@zcot zcot closed this as completed Mar 30, 2020
@zcot zcot reopened this Mar 30, 2020
@asqwerth
Copy link
Author

Thank you. The MX packaging team had previously checked and confirmed that it had a newer version number but was viewed as an update to the original CM. As we did not hear from you for a while and weren't sure how actively this was maintained, we proceeded to carry out internal testing on the fork as a pure update (instead of testing them side by side). It's been working very well. Opened it up for further testing on the public forum itself. So far no issues. I will ask the packaging team and MX devs whether it's more appropriate for cm2 to be seen as an update or as a separate package of its own, if we do decide to implement it in MX Linux.

@zcot
Copy link
Owner

zcot commented Mar 30, 2020

You should point the coders and packagers here, because they will easily understand. ;)

The repo does already show everything.

Additionally, here is where the situation started as a PR against Tony George's original source, and you can check the transaction and see how this fork came about: https://github.com/teejee2008/conky-manager/pulls

Also, possibly of interest, someone on the Linux Mint forum created a flat version of the icon, although I don't know if any or what license is attached to that: https://forums.linuxmint.com/viewtopic.php?f=211&t=312994

And hint, of course, after someone solves hint the issue with automatic detection of network devices, hint and sends the PR, then it can be hint added, 😃 : #14

But, honestly, the more interesting enhancement is adding a viewable log output scheme.

@asqwerth
Copy link
Author

Sorry for the delayed response! Thanks for the additional information. I'll point the devs to this page and the Linuxmint page.

@asqwerth
Copy link
Author

With respect to your comment about having an icon, I modified the conky-manager icon found in Papirus icon theme, since it's under the GPL 3.0 licence.

You are welcome to use it if you wish, and I attach a zip file enclosing 48x48 and 64x64 svg files for the same (licence details also included).

conky-manager2-generic48

conky_manager2-generic-icon.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants