fix: allow zinit to be run from non-interactive scripts #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still two places where [[ -e $local_dir ]] && {
for el ( ${ice_order[@]} ) {
val="${ice[$el]}"
cand1="${(qqq)val}"
cand2="${(qq)val}"
if [[ -n "$val" ]] {
[[ "${cand1/\\\$/}" != "$cand1" || "${cand1/\\\!/}" != "$cand1" ]] && output+=( "$el$cand2" ) || output+=( "$el$cand1" )
} elif [[ ${+ice[$el]} = 1 && -n "${nval_ices[(r)$el]}" ]] {
output+=( "$el" )
}
}In both cases, I do not know what to do with it :-( Also: not sure if this should get a test (and how: given that tests would run in scripts and so would always be non-interactive?). |
|
For the failing documentation test, you should be able to run: zinit make"PREFIX=$ZPFX install" for @zdharma-continuum/zshelldoc
make doc |
|
And if the unit test tests are failing after #226 is merged, I'll look and make sure it isn't related to my work over the weekend. |
vladdoster
changed the title
|
this XKCD seems warranted ;)
|
jankatins
force-pushed
the
dont_escape_exclamation_mark_in_hook_names
branch
from
a0b0f94
to
b439f0d
Compare
|
Manually added the doc change, as I got a real bunch of changes here (mac? Different version?). Also fixed the commit message to be the same as the PR title |
|
The unittest failure looks more like a problem with downloading the wrong file from gh (386 instead of amd64)? #226 ? |
jankatins
force-pushed
the
dont_escape_exclamation_mark_in_hook_names
branch
from
b439f0d
to
2b38534
Compare
|
@vladdoster Rebased and force pushed on top of the 386 fixes in #226 |
|
Looks like it fails here https://github.com/zdharma-continuum/zinit/blob/main/tests/gh-r.zunit#L260 |
|
@vladdoster the failure on github/hub looks a bit strange: So the file is there, but the cp hook returns 1 and therefore the zinit call fails. I wonder if this is actually triggering the codepath which this PR should fix and the cp is simply not executed currently. The current output, e.g. in https://github.com/zdharma-continuum/zinit/runs/6202981953?check_suite_focus=true#step:8:5380 (run of current master)) supports that hypothesis: -> the |
jankatins
force-pushed
the
dont_escape_exclamation_mark_in_hook_names
branch
from
2b38534
to
45e569e
Compare
|
A bit more tracing and this turned out to be these two lines: It seems the return value of the second copy (which didn't find files to copy) was returned from the hook and therefore the hook run marked as failed. Verified with @vladdoster See the second commit here for a possible fix (modeled after the pattern found in the mv hook) |
|
BTW: is there any better way to enable tracing everywhere than |
jankatins
force-pushed
the
dont_escape_exclamation_mark_in_hook_names
branch
3 times, most recently
from
bf71515
to
b371adf
Compare
|
Current failure: I can reproduce locally and the fix is to add a λ zinit delete "tldr-completion/gh-r" -y ; zinit for as"completion" from"gh-r" id-as"tldr-completion/gh-r" bpick"completions_zsh" pick"completions_zsh" @dbrgn/tealdeer
Done (action executed, exit code: 0)
Downloading dbrgn/tealdeer… (at label: tldr-completion/gh-r…)
(Requesting `completions_zsh'…)
############################################################################################################################################################################################################ 100.0%
ziextract: WARNING: didn't recognize the archive type of `completions_zsh' }(no extraction has been done).%f%b
Note: Compiling: completions_zsh… OK.-> Pushed in a separate commit as I'm not completely sure if this need is expected and why this is now failing (no exclamation mark in the hook name) after the fix. |
|
@vladdoster It's green :-) |
|
Even though its green, the workaround seems like there is a regression somewhere, no? |
|
It feels more like the unit tests were having the same problem (I guess they are running non-interactive) and therefore config errors were not noticed. Eg nothing in the tests check for compiling in the tldr gh-r case or for the copied _hub completion file and so the missing hooks didn't lead to errors. And running it interactively will get you a error message but the main functionality is there (hub command and completion for tldr). |
jankatins
commented
May 6, 2022
tests/snippets.zunit
Outdated
| @@ -52,7 +52,7 @@ | |||
| } | |||
| @test 'tldr-completion::gh-r' { | |||
| artifact="$ZINIT[PLUGINS_DIR]/tldr-completion---gh-r" | |||
| run zinit for as"completion" from"gh-r" id-as'tldr-completion/gh-r' bpick"completions_zsh" @dbrgn/tealdeer | |||
| run zinit for as"completion" from"gh-r" id-as'tldr-completion/gh-r' bpick"completions_zsh" pick"completions_zsh" @dbrgn/tealdeer | |||
There was a problem hiding this comment.
My understanding of the need for this is that the compile now fails without this because the compile step wasn't run before in the unit test. After all, it was running non-interactive and triggered the bug, which got fixed in this PR.
There was a problem hiding this comment.
Huh, okay. I'm going to (but feel to if you want) add a check using zi clist or something to ensure that the completion is registered.
There was a problem hiding this comment.
For some reason, both versions neither work on main nor on this branch, at least I didn't find any tldr/tealdeer entries in zinit clist when running it in my console.
There was a problem hiding this comment.
On main and my branch, this one works:
[14:31:37] λ zinit for as"completion" from"gh-r" id-as"tldr-completion/gh-r" bpick"completions_zsh" mv"completions_zsh -> _tldr" pick"_tldr" @dbrgn/tealdeer || echo bad
Downloading dbrgn/tealdeer… (at label: tldr-completion/gh-r…)
(Requesting `completions_zsh'…)
#################################################################################################################################################################################################################### 100.0%
ziextract: WARNING: didn't recognize the archive type of `completions_zsh' }(no extraction has been done).%f%b
completions_zsh -> _tldr
Note: Compiling: _tldr… OK.
Installed 0 completions. They are stored in the $INSTALLED_COMPS array.
Skipped installing 1 completions. They are stored in the $SKIPPED_COMPS array.The SKIPPED is because the symlink in ~/.zinit/completion/ seems to not get removed on delete:
[14:32:48] λ zinit delete tldr-completion/gh-r -y
[14:33:56] λ ls -la ../completions/_tldr
lrwxr-xr-x 1 jankatins staff 60 May 6 14:30 ../completions/_tldr -> /Users/jankatins/.zinit/plugins/tldr-completion---gh-r/_tldr
[14:34:22] λ ls -la /Users/jankatins/.zinit/plugins/tldr-completion---gh-r/_tldr
ls: /Users/jankatins/.zinit/plugins/tldr-completion---gh-r/_tldr: No such file or directory
[14:34:37] [1] ✗ zinit delete tldr-completion/gh-r -y
No such (plugin or snippet): tldr-completion/gh-r.
-> Will adjust the test but I can also imagine that there is some better way to handle a as"completion" which does not install a completion.
jankatins
commented
May 6, 2022
| ( () { setopt localoptions noautopushd; builtin cd -q "$dir"; } || return 1 | ||
| afr=( ${~from}(DN) ) | ||
| if (( ${#afr} )) { | ||
| if (( !OPTS[opt_-q,--quiet] )) { | ||
| command cp -vf "${afr[1]}" "$to" | ||
| retval=$? | ||
| # ignore errors if no compiled file is found | ||
| command cp -vf "${afr[1]}".zwc "$to".zwc 2>/dev/null |
There was a problem hiding this comment.
Same here: the cp hook wasn't run and therefore the second cp which tries to copy the compiled files fails now. Pattern with retval is the same as a few lines above in mv hook.
jankatins
force-pushed
the
dont_escape_exclamation_mark_in_hook_names
branch
from
05f7f9d
to
cb35b75
Compare
|
I'm also really wanting @psprint to look over this. This has been why I've held off on merging this. No personal qualms with changeset -- this fixes a huge bug in Zinit functionality (and makes the behavior consistent) :^). |
My understanding of this bug+fix is that it only changes behavior for non-interactive usages. So i think it will still not work. Will test tomorrow/day after when I'm back at my laptop. |
Co-authored-by: Philipp Schmitt <pschmitt@users.noreply.github.com>
Exclamation marks (per default) get escaped in interactive mode, but not in non-interactive modes. In this case it meant that zinit would not find any hooks which implements the ices when running in non-interactive mode (e.g. in a script). This in turn would NOT result in errors but would just silently not execute any of the ices which of course would be a bad thing(tm). zdharma-continuum#199 has the details... Closes: zdharma-continuum#199
This would otherwise bubble up as a hook failure and further up as a zinit call failure
After the fix, the compile hook is now run and would fail without this information. IN addition, only files starting with _ are linked into the completion folder.
jankatins
force-pushed
the
dont_escape_exclamation_mark_in_hook_names
branch
from
7461754
to
fc77c1c
Compare
|
Results of the above commands: But after opening a new shell: |
jankatins
force-pushed
the
dont_escape_exclamation_mark_in_hook_names
branch
from
fc77c1c
to
a115aa3
Compare
|
It looks good to me.
… Message ID: ***@***.***>
|
|
@psprint Thank you for a stamp of approval. @jankatins Zunit tests failed due to network (API rate limiting). Kicked off failed zunit tests. Will merge this PR when they pass. @jankatins Thanks again for the work on this fix. :^) |
zunit runs tests non-interactively and these tests fail without the fix in this branch.
jankatins
force-pushed
the
dont_escape_exclamation_mark_in_hook_names
branch
from
a115aa3
to
711916b
Compare
|
@vladdoster / @psprint Woohoo! Restarted the CI by doing a force push |
|
Woohoo, thank you! |
psprint
pushed a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Sep 20, 2022
…inuum#227) * maint: Ignore .idea folder Co-authored-by: Philipp Schmitt <pschmitt@users.noreply.github.com> * fix: Don't escape exclamation marks in hook keys Exclamation marks (per default) get escaped in interactive mode, but not in non-interactive modes. In this case it meant that zinit would not find any hooks which implements the ices when running in non-interactive mode (e.g. in a script). This in turn would NOT result in errors but would just silently not execute any of the ices which of course would be a bad thing(tm). zdharma-continuum#199 has the details... Closes: zdharma-continuum#199 * fix: Ignore errors if cp cannot copy .zwc files This would otherwise bubble up as a hook failure and further up as a zinit call failure * fix: Add pick ice now that the compile hook is run After the fix, the compile hook is now run and would fail without this information. IN addition, only files starting with _ are linked into the completion folder. * fix: Fix docker-buildx gh-r test now that atclone ice is run * maint: Add basic tests for cp/mv/atclone/make ices zunit runs tests non-interactively and these tests fail without the fix in this branch. Co-authored-by: Philipp Schmitt <pschmitt@users.noreply.github.com>
|
The thread is long and difficult to follow. Could someone summarize the
problem so that I could provide some input as requested ?
czw., 9 cze 2022, 11:09 użytkownik Jan Katins ***@***.***>
napisał:
… Removed the alist commit again, rebased and force pushed. -> green
—
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOE4CDIBELTZUVCKQ7RBDLVOGYCXANCNFSM5UIY6CMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@psprint Summary is in the description, copied below to get it into the mail. The original issue is fixed via c3d1bb5 Given that issue was undiscovered for ages, it seems a lot of ices are not covered by actual tests (e.g. test just adds an ice, but does not assure that the ice had an effect).
|
|
@jankatins This broke patch-dl ice |
5 tasks
|
It probably broke the annexes because I removed all |
jankatins
commented
Oct 17, 2022
| @@ -451,9 +451,9 @@ builtin source "${ZINIT[BIN_DIR]}/zinit-side.zsh" || { | |||
| # Store ices at clone of a plugin | |||
| .zinit-store-ices "$local_path/._zinit" ICE "" "" "" "" | |||
| reply=( | |||
| ${(on)ZINIT_EXTS2[(I)zinit hook:\\\!atclone-pre <->]} | |||
| ${(on)ZINIT_EXTS[(I)z-annex hook:\\\!atclone-<-> <->]} | |||
There was a problem hiding this comment.
@vladdoster Probably this changed line broke zdharma-continuum/zinit-annex-patch-dl#6
... and the similar changes to ZINIT_EXTS lines below...
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
# [3.8.0](v3.7.0...v3.8.0) (2022-11-07) ### Bug Fixes * account for systems where musl is present ([#269](#269)) ([8620574](8620574)) * alist repository for gh-r test ([#305](#305)) ([fb3c082](fb3c082)) * allow zinit to be run from non-interactive scripts ([#227](#227)) ([c3d1bb5](c3d1bb5)), closes [#199](#199) * broken yaml syntax in issue template ([#355](#355)) ([f729e06](f729e06)) * calico gh-r zunit test ([#356](#356)) ([56fb9e0](56fb9e0)) * change ctags symbols browser key binding from `ctrl-k` to `alt-Q` ([#387](#387)) ([7f6dc7d](7f6dc7d)), closes [#386](#386) * Do not try to escape exclamation marks ([#399](#399)) ([0e55b2e](0e55b2e)) * docs workflow should fail if out-of-date ([#278](#278)) ([07cde66](07cde66)) * Don't error if $OPTS is not yet defined in .zinit-compinit call ([44765e0](44765e0)) * filter by runtime detected CPU before compiled CPU ([#304](#304)) ([a4dc13f](a4dc13f)), closes [#287](#287) * gh-r & plugin zunit tests ([dd12fce](dd12fce)) * gh-r filters i686 (32 bit) for x86_64 ([#226](#226)) ([57f0d82](57f0d82)), closes [#225](#225) * gh-r logic ignores [36]86 assets ([#235](#235)) ([d60638f](d60638f)), closes [#225](#225) [#246](#246) [#247](#247) * gh-r removes linux32 assets on 64 bit OS ([1864c0b](1864c0b)) * gh-r retrieves release data GH REST API ([#373](#373)) ([4a2a120](4a2a120)), closes [#374](#374) * modify regex in gh-r for assets to not consider for selection ([#244](#244)) ([6ef8439](6ef8439)) * more cleaning up urls ([672ae51](672ae51)), closes [#47](#47) * names of ctag Make target deps ([#407](#407)) ([9987d5c](9987d5c)) * package are broken again ([24f10f6](24f10f6)) * permissions for PR labeler GH action workflow ([#236](#236)) ([8a0d567](8a0d567)) * read without -r is generally bad. ([00c70a4](00c70a4)) * remove curl option "--tcp-fastopen" which is not always available ([#299](#299)) ([308c9d4](308c9d4)) * remove macOS 10.5 & 11 from test matrix ([c613193](c613193)) * remove use less line ([4f87076](4f87076)) * rename `docs` to `doc` to match doc dir ([#212](#212)) ([3a7dc95](3a7dc95)) * rm linux32 assets in aarch64/arm64 gh-r regex ([#414](#414)) ([529aa20](529aa20)) * syntax error when checking for `realpath` command ([#259](#259)) ([05559eb](05559eb)), closes [#257](#257) * trigger for PR labeler GH action workflow ([#237](#237)) ([49af866](49af866)) * typo & triggers in documentation workflow ([#308](#308)) ([161d7c1](161d7c1)) * unmatched "(" in windows gh-r patterns ([#280](#280)) ([1f4ba5a](1f4ba5a)) * update `zdharma` to `zdharma-continuum` ([66b1700](66b1700)) * update docs for new jq-check ([6207427](6207427)) * use [*] inside arbitrary strings. ([73a8c92](73a8c92)) * workflow pkg mgmt due to base OS changes ([195f72d](195f72d)) * ziextract execs discovery regex ([#410](#410)) ([105b38a](105b38a)) * zunit install in GH workflow ([#412](#412)) ([f4787dc](f4787dc)) ### Features * ability to set program for `zinit ls` to use ([#221](#221)) ([bad7af3](bad7af3)), closes [#170](#170) * add `-a` (actual time) to `zinit times` cmd ([#223](#223)) ([450d3c1](450d3c1)) * add `krew` and `prebuilt-ripgrep` gh-r zunit tests ([#267](#267)) ([f25b4ae](f25b4ae)) * add compile vim from source zunit test ([#232](#232)) ([126528c](126528c)) * add configure"" ice ([#334](#334)) ([40a46c6](40a46c6)) * add GH action to remove old workflow logs ([#248](#248)) ([6647bdc](6647bdc)) * add PR labeler to show what parts of Zinit are changed ([#211](#211)) ([42e83d7](42e83d7)) * add releases via semantic-release ([73542b4](73542b4)) * add releases via semantic-release ([#415](#415)) ([cfa2f0e](cfa2f0e)) * expand linted file types to markdown and shell ([96fe03f](96fe03f)) * **git-process-output:** simplify progress-bar ([#204](#204)) ([c888917](c888917)) * update output messaging to be more informative ([047320a](047320a))
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
psprint
pushed a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 30, 2022
…inuum#227) * maint: Ignore .idea folder Co-authored-by: Philipp Schmitt <pschmitt@users.noreply.github.com> * fix: Don't escape exclamation marks in hook keys Exclamation marks (per default) get escaped in interactive mode, but not in non-interactive modes. In this case it meant that zinit would not find any hooks which implements the ices when running in non-interactive mode (e.g. in a script). This in turn would NOT result in errors but would just silently not execute any of the ices which of course would be a bad thing(tm). zdharma-continuum#199 has the details... Closes: zdharma-continuum#199 * fix: Ignore errors if cp cannot copy .zwc files This would otherwise bubble up as a hook failure and further up as a zinit call failure * fix: Add pick ice now that the compile hook is run After the fix, the compile hook is now run and would fail without this information. IN addition, only files starting with _ are linked into the completion folder. * fix: Fix docker-buildx gh-r test now that atclone ice is run * maint: Add basic tests for cp/mv/atclone/make ices zunit runs tests non-interactively and these tests fail without the fix in this branch. Co-authored-by: Philipp Schmitt <pschmitt@users.noreply.github.com>
psprint
pushed a commit
to psprint/.priv-zinit-fork
that referenced
this pull request
Dec 30, 2022
# [3.8.0](zdharma-continuum/zinit@v3.7.0...v3.8.0) (2022-11-07) ### Bug Fixes * account for systems where musl is present ([zdharma-continuum#269](zdharma-continuum#269)) ([8620574](zdharma-continuum@8620574)) * alist repository for gh-r test ([zdharma-continuum#305](zdharma-continuum#305)) ([fb3c082](zdharma-continuum@fb3c082)) * allow zinit to be run from non-interactive scripts ([zdharma-continuum#227](zdharma-continuum#227)) ([c3d1bb5](zdharma-continuum@c3d1bb5)), closes [zdharma-continuum#199](zdharma-continuum#199) * broken yaml syntax in issue template ([zdharma-continuum#355](zdharma-continuum#355)) ([f729e06](zdharma-continuum@f729e06)) * calico gh-r zunit test ([zdharma-continuum#356](zdharma-continuum#356)) ([56fb9e0](zdharma-continuum@56fb9e0)) * change ctags symbols browser key binding from `ctrl-k` to `alt-Q` ([zdharma-continuum#387](zdharma-continuum#387)) ([7f6dc7d](zdharma-continuum@7f6dc7d)), closes [zdharma-continuum#386](zdharma-continuum#386) * Do not try to escape exclamation marks ([zdharma-continuum#399](zdharma-continuum#399)) ([0e55b2e](zdharma-continuum@0e55b2e)) * docs workflow should fail if out-of-date ([zdharma-continuum#278](zdharma-continuum#278)) ([07cde66](zdharma-continuum@07cde66)) * Don't error if $OPTS is not yet defined in .zinit-compinit call ([44765e0](zdharma-continuum@44765e0)) * filter by runtime detected CPU before compiled CPU ([zdharma-continuum#304](zdharma-continuum#304)) ([a4dc13f](zdharma-continuum@a4dc13f)), closes [zdharma-continuum#287](zdharma-continuum#287) * gh-r & plugin zunit tests ([dd12fce](zdharma-continuum@dd12fce)) * gh-r filters i686 (32 bit) for x86_64 ([zdharma-continuum#226](zdharma-continuum#226)) ([57f0d82](zdharma-continuum@57f0d82)), closes [zdharma-continuum#225](zdharma-continuum#225) * gh-r logic ignores [36]86 assets ([zdharma-continuum#235](zdharma-continuum#235)) ([d60638f](zdharma-continuum@d60638f)), closes [zdharma-continuum#225](zdharma-continuum#225) [zdharma-continuum#246](zdharma-continuum#246) [zdharma-continuum#247](zdharma-continuum#247) * gh-r removes linux32 assets on 64 bit OS ([1864c0b](zdharma-continuum@1864c0b)) * gh-r retrieves release data GH REST API ([zdharma-continuum#373](zdharma-continuum#373)) ([4a2a120](zdharma-continuum@4a2a120)), closes [zdharma-continuum#374](zdharma-continuum#374) * modify regex in gh-r for assets to not consider for selection ([zdharma-continuum#244](zdharma-continuum#244)) ([6ef8439](zdharma-continuum@6ef8439)) * more cleaning up urls ([672ae51](zdharma-continuum@672ae51)), closes [zdharma-continuum#47](zdharma-continuum#47) * names of ctag Make target deps ([zdharma-continuum#407](zdharma-continuum#407)) ([9987d5c](zdharma-continuum@9987d5c)) * package are broken again ([24f10f6](zdharma-continuum@24f10f6)) * permissions for PR labeler GH action workflow ([zdharma-continuum#236](zdharma-continuum#236)) ([8a0d567](zdharma-continuum@8a0d567)) * read without -r is generally bad. ([00c70a4](zdharma-continuum@00c70a4)) * remove curl option "--tcp-fastopen" which is not always available ([zdharma-continuum#299](zdharma-continuum#299)) ([308c9d4](zdharma-continuum@308c9d4)) * remove macOS 10.5 & 11 from test matrix ([c613193](zdharma-continuum@c613193)) * remove use less line ([4f87076](zdharma-continuum@4f87076)) * rename `docs` to `doc` to match doc dir ([zdharma-continuum#212](zdharma-continuum#212)) ([3a7dc95](zdharma-continuum@3a7dc95)) * rm linux32 assets in aarch64/arm64 gh-r regex ([zdharma-continuum#414](zdharma-continuum#414)) ([529aa20](zdharma-continuum@529aa20)) * syntax error when checking for `realpath` command ([zdharma-continuum#259](zdharma-continuum#259)) ([05559eb](zdharma-continuum@05559eb)), closes [zdharma-continuum#257](zdharma-continuum#257) * trigger for PR labeler GH action workflow ([zdharma-continuum#237](zdharma-continuum#237)) ([49af866](zdharma-continuum@49af866)) * typo & triggers in documentation workflow ([zdharma-continuum#308](zdharma-continuum#308)) ([161d7c1](zdharma-continuum@161d7c1)) * unmatched "(" in windows gh-r patterns ([zdharma-continuum#280](zdharma-continuum#280)) ([1f4ba5a](zdharma-continuum@1f4ba5a)) * update `zdharma` to `zdharma-continuum` ([66b1700](zdharma-continuum@66b1700)) * update docs for new jq-check ([6207427](zdharma-continuum@6207427)) * use [*] inside arbitrary strings. ([73a8c92](zdharma-continuum@73a8c92)) * workflow pkg mgmt due to base OS changes ([195f72d](zdharma-continuum@195f72d)) * ziextract execs discovery regex ([zdharma-continuum#410](zdharma-continuum#410)) ([105b38a](zdharma-continuum@105b38a)) * zunit install in GH workflow ([zdharma-continuum#412](zdharma-continuum#412)) ([f4787dc](zdharma-continuum@f4787dc)) ### Features * ability to set program for `zinit ls` to use ([zdharma-continuum#221](zdharma-continuum#221)) ([bad7af3](zdharma-continuum@bad7af3)), closes [zdharma-continuum#170](zdharma-continuum#170) * add `-a` (actual time) to `zinit times` cmd ([zdharma-continuum#223](zdharma-continuum#223)) ([450d3c1](zdharma-continuum@450d3c1)) * add `krew` and `prebuilt-ripgrep` gh-r zunit tests ([zdharma-continuum#267](zdharma-continuum#267)) ([f25b4ae](zdharma-continuum@f25b4ae)) * add compile vim from source zunit test ([zdharma-continuum#232](zdharma-continuum#232)) ([126528c](zdharma-continuum@126528c)) * add configure"" ice ([zdharma-continuum#334](zdharma-continuum#334)) ([40a46c6](zdharma-continuum@40a46c6)) * add GH action to remove old workflow logs ([zdharma-continuum#248](zdharma-continuum#248)) ([6647bdc](zdharma-continuum@6647bdc)) * add PR labeler to show what parts of Zinit are changed ([zdharma-continuum#211](zdharma-continuum#211)) ([42e83d7](zdharma-continuum@42e83d7)) * add releases via semantic-release ([73542b4](zdharma-continuum@73542b4)) * add releases via semantic-release ([zdharma-continuum#415](zdharma-continuum#415)) ([cfa2f0e](zdharma-continuum@cfa2f0e)) * expand linted file types to markdown and shell ([96fe03f](zdharma-continuum@96fe03f)) * **git-process-output:** simplify progress-bar ([zdharma-continuum#204](zdharma-continuum#204)) ([c888917](zdharma-continuum@c888917)) * update output messaging to be more informative ([047320a](zdharma-continuum@047320a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclamation marks (per default) get escaped in interactive mode, but not in non-interactive modes. In this case it meant that zinit would not find any hooks which implements the ices when running in non-interactive mode (e.g. in a script). This in turn would NOT result in errors but would just silently not execute any of the ices which of course would be a bad thing(tm).
This actually happened in the zunit tests as they run non-interactively and therefore any ices based on exclamation mark hooks were not ran. I fixed the few places where (after the fix in this PR) the ice were actually ran and errored due to mis-specifications. I also added explicit checks for a few ices. -> before this PR, ices are basically not tested (and the exclamation mark hook based ones not testable at all!) :-(
Description
This a) disables history mark expansion during hook register and changes any search pattern to not include the (double) escaped exclamation mark
Motivation and Context
It broke using zinit calls with ices in scripts (e.g. from a $HOME bootstrap script or an update script)
#199 has the details...
Closes: #199
How Has This Been Tested?
See the new zunit tests and a few fixes in old tests which were needed because the actual ices were not run beforehand and therefore didn't error when they were not specified correctly.
Running the same ice (mv in this case) interactively and in a script. Both calls contain the
direnv.darwin-amd64 -> direnvlog line.Types of changes
Checklist: