Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for the unauthorized android device do exit with code 0 #190

Closed
vdelendik opened this issue Aug 1, 2023 · 3 comments
Closed

for the unauthorized android device do exit with code 0 #190

vdelendik opened this issue Aug 1, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@vdelendik
Copy link
Contributor

vdelendik commented Aug 1, 2023

there is no sense to restart appium container if device state is unauthorized (somebody cleaned trusted keys on device?!)
for that case let's do exit 0 to avoid permanent restart.

on this line we should exit with error code 1:

exit 3

@vdelendik vdelendik added the enhancement New feature or request label Aug 1, 2023
@vdelendik vdelendik added this to the 2.0 milestone Aug 1, 2023
@vdelendik vdelendik modified the milestones: 2.0, 2.1 Aug 1, 2023
@vdelendik
Copy link
Contributor Author

let's review how it works using existing code for upcoming 2.0

@vdelendik vdelendik modified the milestones: 2.1, 2.0.11 Jan 10, 2024
@akamarouski akamarouski modified the milestones: 2.0.11, 2.0.12 Feb 6, 2024
@vdelendik
Copy link
Contributor Author

in case of unauthorized device we do exit 1 in device_connect.sh and as result exit 0 from appium:

exit 1

echo "Exiting without restarting..."

confirmed that in appium:2.0.11 we try to do usbreset

@dhreben
Copy link
Contributor

dhreben commented Feb 29, 2024

Verified.

error: device unauthorized.
This adb server's $ADB_VENDOR_KEYS is not set
Try 'adb kill-server' if that seems wrong.
Otherwise check for a confirmation dialog on your device.
Not documented device state: ''. One more attempt in 5 seconds.
Restarting...
Doing usbreset forcibly on attached device
Resetting USB device /dev/bus/usb/001/021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants