Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate semaphore file creation removal on session start/finish #377

Closed
vdelendik opened this issue Apr 26, 2024 · 2 comments
Closed

integrate semaphore file creation removal on session start/finish #377

vdelendik opened this issue Apr 26, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@vdelendik
Copy link
Contributor

  1. find place in appium sources where session created successfully, session message is generated (base-driver?)
    old logic which used it to determine startedSessionId is here:

    startedSessionId=`grep -E -m 1 " session created successfully, session " ${TASK_LOG} | cut -d " " -f 10 | cut -d " " -f 1`

  2. inject file creation $LOG_DIR/.recording-artifact with such content on this step:

sessionId=<session-uuid>
  1. find place in appum sources where session is finished (TBD if we can support negative scenarios as well)
    example:
    finishedSessionId=`grep -E -m 1 " DELETE /wd/hub/session/$startedSessionId " ${TASK_LOG} | cut -d "/" -f 5 | cut -d " " -f 1`
  2. inject $LOG_DIR/.recording-artifact file removal on above step
@vdelendik vdelendik added the enhancement New feature or request label Apr 26, 2024
@vdelendik vdelendik added this to the 2.1 milestone Apr 26, 2024
@vdelendik
Copy link
Contributor Author

please, start implementation using recorder-2.0 branch

@dhreben
Copy link
Contributor

dhreben commented May 21, 2024

Basic acceptance successfully completed. Video, screenshots and logs are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants