Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide screen works selectively on iOS 17 #888

Closed
amastej opened this issue Feb 16, 2024 · 5 comments
Closed

Show/Hide screen works selectively on iOS 17 #888

amastej opened this issue Feb 16, 2024 · 5 comments
Labels
Milestone

Comments

@amastej
Copy link

amastej commented Feb 16, 2024

Steps

  1. Open STF and log in
  2. Select device with iOS 17 (iPhone 11 or iPhone SE)
  3. Click on "show/hide" icon

Actual result
System works selectively on devices with iOS 17

Nagranie.z.ekranu.2024-02-16.o.14.56.28.mp4

Expected result
Show/Hide screen works correctly

@amastej amastej added the bug label Feb 16, 2024
@ignacionar
Copy link
Collaborator

ignacionar commented Mar 4, 2024

The hide screen button is working correctly (disconnects from websocket).

When toggling to show screen the reconnection to the stream takes more time than others iOS devices (however, it reconnects and shows the screen after a couple of seconds).

&& (ws && ws.readyState === WebSocket.OPEN)

This will be faster or slower depending on the device.

@vdelendik
Copy link
Contributor

Speed depends on resolution that’s why on small screens like SE it is pretty fast.

@ignacionar
Copy link
Collaborator

@vdelendik It would be possible to just hide the device screen (css) instead of closing the WS connection. Should we just stick to the current approach or hide with css styles?

@vdelendik
Copy link
Contributor

@dhreben, could you please retest. As I remember @ignacionar fixed iOS websocket reconnect stuff.
Goal to keep consistency and as in Android disconnect/connect websocket.

@github-project-automation github-project-automation bot moved this from To do to Ready For QA in Device Farm (MCloud) Sep 16, 2024
@vdelendik vdelendik added this to the 3.0 milestone Sep 16, 2024
@dhreben
Copy link
Contributor

dhreben commented Sep 18, 2024

Fixed

@dhreben dhreben moved this from Ready For QA to Done in Device Farm (MCloud) Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants